Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0] FIX import XML with invalid URI #910

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Jan 29, 2019

Recovering parser is needed for files where strings like
xmlns:ds="http://www.w3.org/2000/09/xmldsig#""
are present: even if lxml raises
{XMLSyntaxError}xmlns:ds: 'http://www.w3.org/2000/09/xmldsig#"' is not a valid URI
such files are accepted by SDI

xmlns:ds="http://www.w3.org/2000/09/xmldsig#""
are present: even if lxml raises
{XMLSyntaxError}xmlns:ds: 'http://www.w3.org/2000/09/xmldsig#"' is not a valid URI
such files are accepted by SDI
Copy link
Contributor

@GSLabIt GSLabIt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eLBati eLBati merged commit 6f4ed24 into OCA:11.0 Feb 5, 2019
SimoRubi pushed a commit to SimoRubi/l10n-italy that referenced this pull request Aug 7, 2019
xmlns:ds="http://www.w3.org/2000/09/xmldsig#""
are present: even if lxml raises
{XMLSyntaxError}xmlns:ds: 'http://www.w3.org/2000/09/xmldsig#"' is not a valid URI
such files are accepted by SDI
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Feb 27, 2023
Signed-off-by dreispt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants