Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] l10n_it_fatturapa_pec: filename without colon #3806

Merged
merged 1 commit into from
Jan 8, 2024
Merged

[FIX] l10n_it_fatturapa_pec: filename without colon #3806

merged 1 commit into from
Jan 8, 2024

Conversation

mde-scopea
Copy link
Contributor

@mde-scopea mde-scopea commented Jan 2, 2024 •
edited
Loading

Fix colon in filename

#3805
#3500

@mde-scopea mde-scopea mentioned this pull request Jan 2, 2024
Closed
3 tasks
SirAionTech
SirAionTech requested changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only code review, looks good to me.

Please fix the commit message and PR name/description: they should mention colon (the punctuation mark :) not column
image

@mde-scopea mde-scopea changed the title [FIX] l10n_it_fatturapa_pec: filename without column [FIX] l10n_it_fatturapa_pec: filename without colon Jan 2, 2024
@mde-scopea mde-scopea force-pushed the 14.0-fix-l10n_it_fatturapa_pec-colon_file_name branch from ecdadff to 55fd841 Compare January 2, 2024 16:23
@mde-scopea
Copy link
Contributor Author

@SirAionTech my bad
Correction done

odooNextev
odooNextev approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@odooNextev odooNextev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@eLBati
Copy link
Member

eLBati commented Jan 8, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-3806-by-eLBati-bump-patch, awaiting test results.

@francesco-ooops francesco-ooops linked an issue Jan 8, 2024 that may be closed by this pull request
not possible to update/clone the repo on a Windows operating system. #3805
Closed
3 tasks
@OCA-git-bot OCA-git-bot merged commit cce1f16 into OCA:14.0 Jan 8, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4ce92e8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odooNextev odooNextev odooNextev approved these changes

@SirAionTech SirAionTech SirAionTech approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

not possible to update/clone the repo on a Windows operating system.
5 participants
@mde-scopea @OCA-git-bot @eLBati @odooNextev @SirAionTech