[ADD] l10n_it_fatturapa_import_zip #3587

SirAionTech · 2023-09-19T07:51:01Z

Sostituisce #3526.
Implementa #3510 per 14.0.

micheledic

Fatto un po' di prove e sembra OK!

sergiocorato · 2023-09-21T08:41:00Z

l10n_it_fatturapa_import_zip/wizards/wizard_import_fatturapa.py

+        return result
+
+    def _get_invoice_partner_id(self, fatt):
+        if self._is_import_attachment_out():


Qui bypassi la funzione getCedPrest che si occupa di caricare l'indirizzo completo del partner, per cui viene creato solo con la P.I. se non presente.

Si potrebbe recuperare la funzione getCessComm che era usata nella versione 12.0 di questo modulo.

Eh sì viene creato un partner proprio con il minimo indispensabile: nome, cognome, codice fiscale, partita IVA, nazione e poco altro.
Secondo me è già un buon inizio e si potrebbe iniziare a usare già così, però capisco che sia migliorabile.

Non esiste la versione 12.0 di questo modulo, mi puoi dare un riferimento al codice di cui scrivevi?
Ovviamente puoi anche proporre la modifica al branch di questa PR.

SirAionTech · 2023-10-19T12:37:27Z

Aggiornamento (tardivo): la PR equivalente per 16.0 (#3584) è stata mergiata

matteoopenf · 2023-10-30T16:23:48Z

Aggiornamento (tardivo): la PR equivalente per 16.0 (#3584) è stata mergiata

se la pr omologa e' stata mergiata possiamo valutare il merge di questa?

matteoopenf

ho provato il modulo funzionalmente il modulo e funziona perfettamente, approvazione funzionale

OCA-git-bot · 2023-11-02T16:46:34Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

andreampiovesana · 2023-11-03T15:12:14Z

@sergiocorato ok? merge?

matteoopenf · 2023-11-09T09:52:21Z

@sergiocorato per caso anche per te e' ok?

matteoopenf · 2023-11-22T09:02:08Z

@sergiocorato remind

matteoopenf · 2023-11-23T11:48:40Z

per caso si riesce a mergiare?

andreampiovesana · 2023-12-04T15:16:46Z

merge?

…mportare in massa e-fatture in/out

Also allow to create withholding taxes in other tests

Do not assume there is a `/tmp` directory or that path separator is `/` so that this can also work in other FileSystems than Linux's

Override exposed methods instead of duplicating Reuse common tests data

Sometimes the file that is being read still hasn't been written completely so it is not recognized as a zip file during parsing and raises exception "BadZipfile: File is not a zip file".

Also add new contributor

The signature of fatturapa.attachment.out.get_invoice_obj must be the same of fatturapa.attachment.in.get_invoice_obj because the same method is called on both objects

SirAionTech · 2023-12-06T16:55:55Z

Ho fatto rebase e aggiunto qualche modifica dovuta a cambiamenti nelle dipendenze/linting.

@OCA/local-italy-maintainers si può mergiare prima che cambino altre cose?
Mi sembra ci siano abbastanza revisioni, @sergiocorato cosa ne pensi?

sergiocorato

Eventuali miglioramenti in seguito.

sergiocorato · 2023-12-13T13:40:48Z

/ocabot merge nobump

OCA-git-bot · 2023-12-13T13:40:58Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-3587-by-sergiocorato-bump-nobump, awaiting test results.

OCA-git-bot · 2023-12-13T14:07:31Z

Congratulations, your PR was merged at ae3fcaa. Thanks a lot for contributing to OCA. ❤️

SirAionTech mentioned this pull request Sep 19, 2023

[ADD] l10n_it_fatturapa_import_zip #3526

Closed

SirAionTech marked this pull request as ready for review September 19, 2023 08:05

tafaRU mentioned this pull request Sep 19, 2023

Migration to version 14.0 #1905

Open

74 tasks

micheledic approved these changes Sep 19, 2023

View reviewed changes

sergiocorato reviewed Sep 21, 2023

View reviewed changes

SirAionTech requested a review from sergiocorato September 26, 2023 16:08

eLBati mentioned this pull request Oct 4, 2023

Importazione di fatture elettroniche attive e passive da zip #3510

Closed

2 tasks

matteoopenf approved these changes Nov 2, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Nov 2, 2023

gosto94 approved these changes Nov 2, 2023

View reviewed changes

Borruso and others added 7 commits December 6, 2023 16:50

[ADD] l10n_it_fatturapa_import_zip: aggiunto modulo che permette di i…

1aed198

…mportare in massa e-fatture in/out

[REF] l10n_it_fatturapa_in: Allow overrides for importing invoices

0a5106e

Also allow to create withholding taxes in other tests

[IMP] l10n_it_fatturapa_import_zip: FS-Agnostic file management

a486830

Do not assume there is a `/tmp` directory or that path separator is `/` so that this can also work in other FileSystems than Linux's

[REF] l10n_it_fatturapa_import_zip: Invoices creation

ee9e3ce

Override exposed methods instead of duplicating Reuse common tests data

[FIX] l10n_it_fatturapa_import_zip: Prevent bad zip file

82a767d

Sometimes the file that is being read still hasn't been written completely so it is not recognized as a zip file during parsing and raises exception "BadZipfile: File is not a zip file".

[REF] l10n_it_fatturapa_in: Allow override for invoice partner

9ec9a04

[FIX] l10n_it_fatturapa_import_zip: Customer is CessionarioCommittente

04e0677

SirAionTech force-pushed the 14.0-mig-l10n_it_fatturapa_import_zip branch from f7ab6fe to 04e0677 Compare December 6, 2023 15:50

SirAionTech marked this pull request as draft December 6, 2023 15:54

SirAionTech added 2 commits December 6, 2023 17:01

[REF] l10n_it_fatturapa_import_zip: Adapt to new linting

cf10fc8

Also add new contributor

[FIX] l10n_it_fatturapa_import_zip: Adapt to new signature

f6fa900

The signature of fatturapa.attachment.out.get_invoice_obj must be the same of fatturapa.attachment.in.get_invoice_obj because the same method is called on both objects

SirAionTech marked this pull request as ready for review December 6, 2023 16:55

sergiocorato approved these changes Dec 13, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Dec 13, 2023

OCA-git-bot merged commit 62f3da4 into OCA:14.0 Dec 13, 2023
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 13, 2023

francesco-ooops added the new module label Jan 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] l10n_it_fatturapa_import_zip #3587

[ADD] l10n_it_fatturapa_import_zip #3587

SirAionTech commented Sep 19, 2023 •

edited

Loading

micheledic left a comment

sergiocorato Sep 21, 2023

SirAionTech Sep 26, 2023

SirAionTech commented Oct 19, 2023

matteoopenf commented Oct 30, 2023

matteoopenf left a comment

OCA-git-bot commented Nov 2, 2023

andreampiovesana commented Nov 3, 2023

matteoopenf commented Nov 9, 2023

matteoopenf commented Nov 22, 2023

matteoopenf commented Nov 23, 2023

andreampiovesana commented Dec 4, 2023

SirAionTech commented Dec 6, 2023

sergiocorato left a comment

sergiocorato commented Dec 13, 2023

OCA-git-bot commented Dec 13, 2023

OCA-git-bot commented Dec 13, 2023

[ADD] l10n_it_fatturapa_import_zip #3587

[ADD] l10n_it_fatturapa_import_zip #3587

Conversation

SirAionTech commented Sep 19, 2023 • edited Loading

micheledic left a comment

Choose a reason for hiding this comment

sergiocorato Sep 21, 2023

Choose a reason for hiding this comment

SirAionTech Sep 26, 2023

Choose a reason for hiding this comment

SirAionTech commented Oct 19, 2023

matteoopenf commented Oct 30, 2023

matteoopenf left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Nov 2, 2023

andreampiovesana commented Nov 3, 2023

matteoopenf commented Nov 9, 2023

matteoopenf commented Nov 22, 2023

matteoopenf commented Nov 23, 2023

andreampiovesana commented Dec 4, 2023

SirAionTech commented Dec 6, 2023

sergiocorato left a comment

Choose a reason for hiding this comment

sergiocorato commented Dec 13, 2023

OCA-git-bot commented Dec 13, 2023

OCA-git-bot commented Dec 13, 2023

SirAionTech commented Sep 19, 2023 •

edited

Loading