Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] Nascondere i codici dei conti nella Stampa Bilancio Contabile #3200

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[IMP] Nascondere i codici dei conti nella Stampa Bilancio Contabile #3200

merged 1 commit into from
Mar 31, 2023

Conversation

SirTakobi
Copy link
Contributor

Implementazione di #3199.

@OCA-git-bot
Copy link
Contributor

Hi @SilvioGregorini,
some modules you are maintaining are being modified, check this out!

@SirTakobi SirTakobi force-pushed the 12.0-imp-l10n_it_account_balance_report-hide_accounts branch from 3e8ec78 to 587cd39 Compare March 2, 2023 14:11
@SirTakobi SirTakobi marked this pull request as ready for review March 2, 2023 14:39
@patrickt-oforce
Copy link
Contributor

@SirTakobi credo che il mantainer Silvio Gregorini possa essere rimosso nel manifest

@eLBati
Copy link
Member

eLBati commented Mar 16, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-3200-by-eLBati-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 16, 2023
@OCA-git-bot
Merge PR #3200 into 12.0
5931fb1 
Signed-off-by eLBati
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

@eLBati your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-3200-by-eLBati-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@eLBati
Copy link
Member

eLBati commented Mar 16, 2023

@SirTakobi puoi verificare https://github.com/OCA/l10n-italy/actions/runs/4436257531/jobs/7784457728 ?

@SirTakobi SirTakobi force-pushed the 12.0-imp-l10n_it_account_balance_report-hide_accounts branch from 587cd39 to 14f6d47 Compare March 22, 2023 10:09
@SirTakobi SirTakobi force-pushed the 12.0-imp-l10n_it_account_balance_report-hide_accounts branch from 14f6d47 to 6e7b901 Compare March 22, 2023 10:10
@SirTakobi
Copy link
Contributor Author

@SirTakobi puoi verificare https://github.com/OCA/l10n-italy/actions/runs/4436257531/jobs/7784457728 ?

La correzione per le versioni di Odoo supportate è odoo/odoo#99538.
È incluso in OCB grazie a OCA/OCB#1166 (infatti in OCB i test sono ✔️)
È stato proposto in Odoo con odoo/odoo#115782.

Aspetterei qualche giorno per vedere se viene mergiato in Odoo.
Se non verrà mergiato in Odoo, c'è la possibilità di escluderei test su Odoo visto che la 12.0 non è più mantenuta (come suggerito in odoo/odoo#115782 (comment)).

@SirTakobi
Copy link
Contributor Author

@SirTakobi puoi verificare https://github.com/OCA/l10n-italy/actions/runs/4436257531/jobs/7784457728 ?

Corretto con #3241.
Credo che il bot faccia già un rebase quando prova a mergiare, quindi non dovrebbe servire un rebase nella PR; puoi riprovare?

@eLBati
Copy link
Member

eLBati commented Mar 31, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-3200-by-eLBati-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 31, 2023
@OCA-git-bot
Merge PR #3200 into 12.0
20f3dc6 
Signed-off-by eLBati
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-3200-by-eLBati-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 31, 2023
@OCA-git-bot
Merge PR #3200 into 12.0
b346ec3 
Signed-off-by eLBati
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-3200-by-eLBati-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7d982a1 into OCA:12.0 Mar 31, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c00b653. Thanks a lot for contributing to OCA. ❤️

@francesco-ooops francesco-ooops mentioned this pull request Dec 22, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eLBati eLBati eLBati approved these changes

@patrickt-oforce patrickt-oforce patrickt-oforce approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SirTakobi @OCA-git-bot @patrickt-oforce @eLBati