Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Importazione fattura elettronica con IVA nei DatiTrasporto non valida #3188

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[FIX] Importazione fattura elettronica con IVA nei DatiTrasporto non valida #3188

merged 1 commit into from
Mar 31, 2023

Conversation

SirTakobi
Copy link
Contributor

@SirTakobi SirTakobi commented Feb 23, 2023 •
edited
Loading

Risolve #3187 per 12.0.

@SirTakobi SirTakobi mentioned this pull request Feb 23, 2023
Open
3 tasks
@SirTakobi SirTakobi force-pushed the 12.0-fix-l10n_it_fatturapa_in-datitrasporto_iva_not_valid branch from 88269bc to 4e0aa7c Compare February 23, 2023 16:20
@SirTakobi SirTakobi marked this pull request as ready for review February 23, 2023 16:20
eLBati
eLBati requested changes Feb 24, 2023
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDI dice "03309970733 - 03533590174 - 1.2.1.1 e 1.2.1.2 non coerenti".
@SirTakobi puoi modificare l'XML di test?
Grazie

@SirTakobi SirTakobi marked this pull request as draft February 24, 2023 10:46
@SirTakobi SirTakobi force-pushed the 12.0-fix-l10n_it_fatturapa_in-datitrasporto_iva_not_valid branch 2 times, most recently from 29ac1f2 to e47140c Compare February 24, 2023 10:55
@SirTakobi
[FIX] l10n_it_fatturapa_in: Skip partner creation if VAT is not valid
72ee0fa 
Only IdTrasmittente, CedentePrestatore, RappresentanteFiscale and CessionarioCommittente have their VAT checked in SdI, so we can't refuse bills where other partners have a VAT that is not valid
@SirTakobi SirTakobi force-pushed the 12.0-fix-l10n_it_fatturapa_in-datitrasporto_iva_not_valid branch from e47140c to 72ee0fa Compare February 24, 2023 10:59
@SirTakobi SirTakobi marked this pull request as ready for review February 24, 2023 11:20
@SirTakobi
Copy link
Contributor Author

Grazie della review!
Puoi verificare se ora va meglio?

eLBati
eLBati approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie

mrcast
mrcast approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@mrcast mrcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test: OK!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@eLBati
Copy link
Member

eLBati commented Mar 24, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-3188-by-eLBati-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 24, 2023
@OCA-git-bot
Merge PR #3188 into 12.0
3cb556a 
Signed-off-by eLBati
@OCA-git-bot
Copy link
Contributor

@eLBati your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-3188-by-eLBati-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@eLBati
Copy link
Member

eLBati commented Mar 31, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-3188-by-eLBati-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 31, 2023
@OCA-git-bot
Merge PR #3188 into 12.0
3ab0a6d 
Signed-off-by eLBati
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-3188-by-eLBati-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b25abec into OCA:12.0 Mar 31, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e041082. Thanks a lot for contributing to OCA. ❤️

@francesco-ooops francesco-ooops linked an issue Dec 22, 2023 that may be closed by this pull request
Importazione fattura elettronica con IVA nei DatiTrasporto non valida #3187
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eLBati eLBati eLBati approved these changes

@mrcast mrcast mrcast approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importazione fattura elettronica con IVA nei DatiTrasporto non valida
4 participants
@SirTakobi @OCA-git-bot @eLBati @mrcast