[12.0][FIX] Il fondo ammortizzato nell'anno precedente non considera tutti gli anni precedenti #3010
Conversation
SirTakobi
changed the title
SirTakobi
force-pushed
the
12.0-fix-assets_management-prev_year_computation
branch
from
a8c1e75
to
144990d
Compare
sergiocorato
changed the title
|
@SirTakobi grazie, puoi forzare il riavvio dei test? |
|
e aprire la issue per la 14.0, visto che adesso il modulo è migrato e non si era tenuto conto di questa |
SirTakobi
force-pushed
the
12.0-fix-assets_management-prev_year_computation
branch
from
144990d
to
05ee201
Compare
Fatto rebase
La issue esisteva già, è #3009: ho aggiornato la parte per |
|
@OCA/local-italy-maintainers che ne dite si può mergiare? Grazie! |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
It looks like something changed on |
|
It looks like something changed on |
|
@eLBati your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-3010-by-eLBati-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
SirTakobi
force-pushed
the
12.0-fix-assets_management-prev_year_computation
branch
from
05ee201
to
f248061
Compare
Forse il bot si era stancato di rifare il branch per le nuove modifiche di |
|
This PR has the |
SirTakobi
force-pushed
the
12.0-fix-assets_management-prev_year_computation
branch
from
f248061
to
61e3c87
Compare
|
/ocabot merge patch |
1 similar comment
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
On my way to merge this fine PR! |
|
@TheMule71 your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-3010-by-TheMule71-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@sergiocorato your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-3010-by-sergiocorato-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
SirTakobi
force-pushed
the
12.0-fix-assets_management-prev_year_computation
branch
from
61e3c87
to
51f50a9
Compare
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at c13ff4e. Thanks a lot for contributing to OCA. ❤️ |
Risolve #3009 per
12.0.Non ho testato il codice per il report previsional perché nel test il totale mi veniva 0 invece di 1000, nonostante da interfaccia il comportamento sia quello atteso.
Suppongo sia un problema mio che non ne so nulla di cespiti 😅 e creavo il test nel modo sbagliato (in pratica uguale al test esistente, ma con il report di tipo 'previsional').
Ad ogni modo, il codice per il report previsional è identico al codice per il report journal quindi penso sia accettabile anche lasciare con un solo test.