Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Ricevere fatture elettroniche in base64 via PEC #2916

Merged
merged 2 commits into from
Feb 27, 2023
Merged

[FIX] Ricevere fatture elettroniche in base64 via PEC #2916

merged 2 commits into from
Feb 27, 2023

Conversation

SirTakobi
Copy link
Contributor

@SirTakobi SirTakobi commented Aug 25, 2022 •
edited
Loading

Risolve #2915 per 12.0.

Nota che questa è probabilmente una regressione introdotta da #2810 perché questo stesso test applicato in 4bae5b8 (quindi subito prima della PR linkata) va a buon fine.
Ho aggiunto anche il test per questo caso d'uso, così si spera che non ci siano più regressioni 👼

@SirTakobi SirTakobi mentioned this pull request Aug 25, 2022
Open
3 tasks
@SirTakobi SirTakobi force-pushed the 12.0-fix-l10n_it_fatturapa_pec-base64_attachment branch from f2a9a4c to 2be5317 Compare August 25, 2022 09:20
@SirTakobi SirTakobi marked this pull request as ready for review August 25, 2022 09:30
@eLBati
Copy link
Member

eLBati commented Aug 26, 2022

Quindi in pratica in 3fb298f ci eravamo dimenticati di portare decoded = base64.b64decode(attachment.datas)?

@SirTakobi
Copy link
Contributor Author

Quindi in pratica in 3fb298f ci eravamo dimenticati di portare decoded = base64.b64decode(attachment.datas)?

Sì, forse perché veniva usato solo nel caso in cui l'allegato è uno zip

eLBati
eLBati requested changes Aug 27, 2022
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chiuderei questa in favore di #2919

@eLBati eLBati mentioned this pull request Aug 27, 2022
Closed
@SirTakobi
Copy link
Contributor Author

Chiuderei questa in favore di #2919

#2919 (review)

eLBati
eLBati approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie

primes2h
primes2h approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@primes2h primes2h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao, grazie per la PR.
La patch funziona correttamente, appena provata su un caso reale.

@primes2h
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-2916-by-primes2h-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit dd764bb into OCA:12.0 Feb 27, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 22f83e1. Thanks a lot for contributing to OCA. ❤️

@SirTakobi SirTakobi mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primes2h primes2h primes2h approved these changes

@eLBati eLBati eLBati approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SirTakobi @eLBati @primes2h @OCA-git-bot