Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] make template data overridable #2787

Merged
merged 2 commits into from
Jul 15, 2022
Merged

[14.0][IMP] make template data overridable #2787

merged 2 commits into from
Jul 15, 2022

Conversation

TheMule71
Copy link
Contributor

Move some methods from efattura.py to the wizard model, to make it easier to override them,

@TheMule71 TheMule71 mentioned this pull request Jun 29, 2022
Closed
@TheMule71 TheMule71 force-pushed the 14.0-imp-make-function-overridable branch from 600c9c2 to a74346a Compare June 29, 2022 13:51
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 29, 2022
@TheMule71
revived with OCA#2787 OCA#2386
d8ccfaa
@TheMule71 TheMule71 mentioned this pull request Jun 29, 2022
Merged
@TheMule71 TheMule71 force-pushed the 14.0-imp-make-function-overridable branch from 95d9b3c to 0875985 Compare June 30, 2022 17:58
@TheMule71 TheMule71 requested a review from tafaRU July 1, 2022 12:45
@TheMule71 TheMule71 force-pushed the 14.0-imp-make-function-overridable branch from 0875985 to fec1bc1 Compare July 15, 2022 07:39
tafaRU
tafaRU requested changes Jul 15, 2022
View reviewed changes
Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per il resto LGTM, ottimo lavoro, thanks!

l10n_it_fatturapa_out/wizard/wizard_export_fatturapa.py Outdated Show resolved Hide resolved
l10n_it_fatturapa_out_rc/views/invoice_it_template.xml Show resolved Hide resolved
@TheMule71 TheMule71 force-pushed the 14.0-imp-make-function-overridable branch from fec1bc1 to b5fd3c1 Compare July 15, 2022 13:19
@TheMule71 TheMule71 force-pushed the 14.0-imp-make-function-overridable branch from b5fd3c1 to 4aa0479 Compare July 15, 2022 13:54
@tafaRU
Copy link
Member

tafaRU commented Jul 15, 2022

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-2787-by-tafaRU-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 7b8a32b into OCA:14.0 Jul 15, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8ca1790. Thanks a lot for contributing to OCA. ❤️

@TheMule71 TheMule71 deleted the 14.0-imp-make-function-overridable branch July 15, 2022 15:01
@matteoopenf matteoopenf mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tafaRU tafaRU tafaRU approved these changes

@matteoopenf matteoopenf matteoopenf approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheMule71 @tafaRU @OCA-git-bot @matteoopenf