Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] [FIX] l10n_it_split_payment: fix payment lines #2336

Merged

Conversation

TheMule71
Copy link
Contributor

Force recompute of all fields instead of just debit/credit.
Fix a failure in l10n_it_fatturapa_out_sp tests.

Descrizione del problema o della funzionalità:
Le righe crediti / debit verso clienti / fornitori vanno modificate in caso di SP. Tuttavia, venivano aggiornati solo credit e debit lasciando inalterati gli altri importi.

Comportamento attuale prima di questa PR:
In una fattura, nelle righe relative ai crediti clienti, veniva modificato solo debit, tutti gli altri campi, in particolare amount_currenty, rimanevano inalterati. l10n_it_fatturapa_out_sp usa "amount_currency or debit" per l'importo della riga e usava il valore non modificato (pre SP).

Comportamento desiderato dopo questa PR:
Aggiornando price_unit della riga, tutti gli altri valori, amount_currency e debit compresi, vengono ricalcolati correttamente.

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@TheMule71 TheMule71 changed the title [FIX] l10n_it_split_payment: fix payment lines [14.0] [FIX] l10n_it_split_payment: fix payment lines Jun 18, 2021
@TheMule71 TheMule71 requested a review from tafaRU June 18, 2021 13:04
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 18, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 18, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 18, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 2, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 2, 2021
@TheMule71 TheMule71 force-pushed the 14.0-fix_l10n_it_split_payment-line-fix branch from aec03f3 to e853dbb Compare July 9, 2021 09:38
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
Force recompute of all fields instead of just debit/credit.
Fix a failure in l10n_it_fatturapa_out_sp tests.
@TheMule71 TheMule71 force-pushed the 14.0-fix_l10n_it_split_payment-line-fix branch from e853dbb to eb4eeae Compare July 16, 2021 08:54
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 17, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 20, 2021
@TheMule71
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-2336-by-TheMule71-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2078d3a into OCA:14.0 Jul 30, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 489e4f8. Thanks a lot for contributing to OCA. ❤️

TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 6, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 6, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 20, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 20, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 3, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 3, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 17, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 17, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 1, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 1, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 8, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 8, 2021
@TheMule71 TheMule71 deleted the 14.0-fix_l10n_it_split_payment-line-fix branch October 15, 2021 16:20
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 29, 2022
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants