Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] l10n_it_website_portal_fiscalcode #2315

Merged
merged 16 commits into from
Jan 14, 2022
Merged

[14.0][MIG] l10n_it_website_portal_fiscalcode #2315

merged 16 commits into from
Jan 14, 2022

Conversation

Borruso
Copy link
Contributor

@Borruso Borruso commented Jun 4, 2021

Migration l10n_it_website_portal_fiscalcode from 12.0 to 14.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@TheMule71 TheMule71 mentioned this pull request Jun 18, 2021
Open
74 tasks
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 18, 2021
@TheMule71
add OCA#2315
71ffcad
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 18, 2021
@TheMule71
add OCA#2315
b0c4300
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 2, 2021
@TheMule71
add OCA#2315
ef79090
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 2, 2021
@TheMule71
add OCA#2315
c06f246
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
@TheMule71
add OCA#2315
7572b1b
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
@TheMule71
add OCA#2315
7aedd18
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
@TheMule71
add OCA#2315
7f2b515
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
@TheMule71
add OCA#2315
95c480e
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 17, 2021
@TheMule71
add OCA#2315
7a1569f
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 20, 2021
@TheMule71
add OCA#2315
a466b03
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
@TheMule71
add OCA#2315
767e237
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
@TheMule71
add OCA#2315
d89f296
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 6, 2021
@TheMule71
add OCA#2315
bb60d86
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 20, 2021
@TheMule71
add OCA#2315
3f01d5d
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 3, 2021
@TheMule71
add OCA#2315
037448b
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 17, 2021
@TheMule71
add OCA#2315
386d3e0
SimoRubi
SimoRubi suggested changes Sep 24, 2021
View reviewed changes
Copy link
Member

@SimoRubi SimoRubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Ho provato il modulo e inserendo un codice fiscale non valido ottengo:
image
Potresti mostrare l'errore in modo meno drammatico?
L'errore di un dato sbagliato nel form dovrebbe essere mostrato come un qualsiasi errore nel form analogamente a quanto succedeva in v12:
image

@Borruso Borruso force-pushed the 14.0-mig-l10n_it_website_portal_fiscalcode branch 2 times, most recently from 89e5e09 to 1412d09 Compare September 24, 2021 16:57
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 1, 2021
@TheMule71
add OCA#2315
070fca8
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 8, 2021
@TheMule71
add OCA#2315
cd5525f
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
@TheMule71
add OCA#2315
83ef1a4
@Borruso Borruso requested a review from SimoRubi October 22, 2021 15:14
SimoRubi
SimoRubi approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@SimoRubi SimoRubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie, ora il messaggio di errore è in linea con gli altri:
image

Ho provato il modulo e fatto revisione del codice; ho aggiunto qualche commento ma secondo me non sono cose bloccanti per il merge quindi per me è ok

l10n_it_website_portal_fiscalcode/controllers/main.py
@@ -34,7 +35,9 @@ def details_form_validate(self, data):
"company_type": company_type,
}
)
if not dummy_partner.check_fiscalcode():
try:
dummy_partner.check_fiscalcode()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visto che check_fiscalcode solleva un'eccezione (diversamente da v12 dove ritornava solo un Booleano), potrebbe avere senso riportare il messaggio di errore all'utente invece di visualizzare sempre "Codice fiscale non valido", che ne pensi?

l10n_it_website_portal_fiscalcode/i18n/it.po Outdated
@@ -1,32 +0,0 @@
# Translation of Odoo Server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come mai le traduzioni sono state rimosse?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pensavo di doverli togliere se servono posso riportarli

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non è necessario rimuoverle, vedi la discussione che inizia con https://discord.com/channels/753902328494424064/822435512391303209/861889733743738890 e in pratica si conclude con:

...
Quindi se non c'è rinomina (non mi ero accorto di aver beccato un caso particolare) anche secondo te va bene lasciarli?
...
Certamente, non vanno rimossi. Il dubbio me lo ero posto solo nel caso particolare.

@primes2h ho riassunto un bel po' la discussione di Discord, fammi sapere se c'è qualcosa da aggiungere

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimoRubi direi di no, nulla da aggiungere. 👍

@Borruso Borruso force-pushed the 14.0-mig-l10n_it_website_portal_fiscalcode branch from 1412d09 to 7be31b5 Compare November 12, 2021 17:13
@Borruso Borruso force-pushed the 14.0-mig-l10n_it_website_portal_fiscalcode branch from 7be31b5 to 5531ee2 Compare November 20, 2021 18:06
OCA-git-bot and others added 12 commits December 10, 2021 10:39
@OCA-git-bot @Borruso
[ADD] icon.png
2838b1c
@eLBati @Borruso
porting l10n_it_website_portal_fiscalcode to 12
7db68cc
@oca-travis @Borruso
[UPD] Update l10n_it_website_portal_fiscalcode.pot
467bc34
@oca-transbot @Borruso
Update translation files
2bffae0 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_website_portal_fiscalcode
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_website_portal_fiscalcode/
@OCA-git-bot @Borruso
[UPD] README.rst
2fd82c8
@eLBati @Borruso
FIX l10n_it_website_portal_fiscalcode check after invoice issuing
99bb83a 
Steps:

 - Create a partner (type company) and give them portal access
 - With the new user, access to portal
 - Edit partner details setting fiscal code with 11 digits
 - Using admin, create an invoice for that partner and validate
 - Using the new user, access to portal, open partner details and save

Get "The fiscal code doesn't seem to be correct"
@oca-travis @Borruso
[UPD] Update l10n_it_website_portal_fiscalcode.pot
878791e
@OCA-git-bot @Borruso
l10n_it_website_portal_fiscalcode 12.0.1.0.1
e93e2b2
@oca-transbot @Borruso
Update translation files
3387207 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_website_portal_fiscalcode
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_website_portal_fiscalcode/
@primes2h @Borruso
Translated using Weblate (Italian)
7a3a87f 
Currently translated at 100.0% (2 of 2 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_website_portal_fiscalcode
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_website_portal_fiscalcode/it/
@Borruso
merge PR 1264 1717 1728 1737 1739
9f826b0
@Borruso
[IMP] l10n_it_website_portal_fiscalcode: black, isort, prettier
d8e6ccb
@Borruso Borruso force-pushed the 14.0-mig-l10n_it_website_portal_fiscalcode branch from 5531ee2 to a7b6b02 Compare December 10, 2021 10:17
@Borruso Borruso force-pushed the 14.0-mig-l10n_it_website_portal_fiscalcode branch from a7b6b02 to 453cbb0 Compare December 10, 2021 12:38
@elvise
Copy link

elvise commented Jan 13, 2022

Ciao, @Borruso qualche chance per il merge ?

@tafaRU
Copy link
Member

tafaRU commented Jan 14, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-2315-by-tafaRU-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 14, 2022
@OCA-git-bot
Merge PR #2315 into 14.0
fcf37a8 
Signed-off-by tafaRU
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-2315-by-tafaRU-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fe9dbd1 into OCA:14.0 Jan 14, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 540dcdc. Thanks a lot for contributing to OCA. ❤️

TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
@TheMule71
add OCA#2315
47a0b2e
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
@TheMule71
add OCA#2315
30863e0
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 29, 2022
@TheMule71
add OCA#2315
3b4a0a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primes2h primes2h primes2h left review comments

@SimoRubi SimoRubi SimoRubi approved these changes

@tafaRU tafaRU tafaRU approved these changes

@scigghia scigghia scigghia approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.