Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14.0 mig l10n it fatturapa in purchase #2229

Merged

Conversation

fredzamoabg
Copy link
Contributor

migrazione modulo l10n_it_fatturapa_in_purchase dalla version 12.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@fredzamoabg fredzamoabg mentioned this pull request Apr 22, 2021
74 tasks
@fredzamoabg fredzamoabg force-pushed the 14.0-mig-l10n_it_fatturapa_in_purchase branch 4 times, most recently from 0bc374b to 226e5fb Compare April 23, 2021 07:49
@fredzamoabg fredzamoabg marked this pull request as ready for review April 23, 2021 08:05
@fredzamoabg fredzamoabg force-pushed the 14.0-mig-l10n_it_fatturapa_in_purchase branch from 226e5fb to 16556ff Compare April 23, 2021 08:06
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Apr 23, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 6, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 18, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 18, 2021
@fredzamoabg fredzamoabg force-pushed the 14.0-mig-l10n_it_fatturapa_in_purchase branch from 16556ff to 61a72c9 Compare July 2, 2021 09:54
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 2, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 2, 2021
@fredzamoabg fredzamoabg force-pushed the 14.0-mig-l10n_it_fatturapa_in_purchase branch from 61a72c9 to 592fb75 Compare July 2, 2021 14:17
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 17, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 20, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 6, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 20, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 3, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 17, 2021
"product_qty",
"product_uom",
"invoice_lines.quantity",
"invoice_lines.uom_id",
"invoice_lines.product_uom_id",
)
def _compute_to_invoice(self):
precision = self.env["decimal.precision"].precision_get(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qui sotto puoi usare line.qty_to_invoice invece di ricalcolarlo?
Oppure puoi includere il calcolo del nuovo campo to_invoice dentro il metodo _compute_qty_invoiced che calcola entrambe le quantità che ti servono.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modifica fatta

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

/>
<record id="view_invoice_form_fatturapa_po_line" model="ir.ui.view">
<field name="name">view_invoice_form_fatturapa_po_line</field>
<field name="model">account.move</field>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come mai hai rimosso la modifica dal form della riga fattura?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

questa deriva dalla modifica in l10n_it_fatturapa (eb32865#diff-1f57cc2debafd446277a8fdffc044c732422dee3e33bd69d6e07f78be1f1812eR15)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recuperando la storia della modifica eb32865#diff-1f57cc2debafd446277a8fdffc044c732422dee3e33bd69d6e07f78be1f1812eR15 ho trovato anche la motivazione per cui non ha senso visualizzare questi campi nelle viste di account.move.line:

Alla fine la vista account.view_move_line_form viene usata per i movimenti contabili, si anche non visualizzare i documenti correlati, perché riguardano l'XML della fattura.

(da #1984 (comment))
Quindi va bene lasciare così 👍🏻

TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 1, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 8, 2021
OCA-git-bot added a commit that referenced this pull request Nov 26, 2021
Signed-off-by tafaRU
@OCA-git-bot
Copy link
Contributor

@tafaRU your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-2229-by-tafaRU-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

@tafaRU your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-2229-by-tafaRU-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@tafaRU
Copy link
Member

tafaRU commented Nov 26, 2021

@tafaRU
Copy link
Member

tafaRU commented Nov 26, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-2229-by-tafaRU-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 26, 2021
Signed-off-by tafaRU
@OCA-git-bot
Copy link
Contributor

@tafaRU your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-2229-by-tafaRU-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sbidoul
Copy link
Member

sbidoul commented Nov 26, 2021

@tafaRU That is because the setup.py is missing for l10n_it_fatturapa_in_purchase. But what I don't understand is why the pre-commit check does not detect it.

@tafaRU
Copy link
Member

tafaRU commented Nov 27, 2021

@sbidoul, thanks for your help! Do you think it could be useful open a issue? On MQT?

@tafaRU
Copy link
Member

tafaRU commented Nov 27, 2021

@fredzamoabg riesegui per favore pre-commit in modo che venga aggiunto setup/l10n_it_fatturapa_in_purchase.

@sbidoul
Copy link
Member

sbidoul commented Nov 28, 2021

@tafaRU issue created OCA/oca-addons-repo-template#93

@TheMule71
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-2229-by-TheMule71-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c00c4a1 into OCA:14.0 Dec 15, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9760ea7. Thanks a lot for contributing to OCA. ❤️

TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.