Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][ADD] l10n_it_withholding_tax - print withholding_tax in invoice #2193

Merged
merged 1 commit into from
May 24, 2021
Merged

[12.0][ADD] l10n_it_withholding_tax - print withholding_tax in invoice #2193

merged 1 commit into from
May 24, 2021

Conversation

aleuffre
Copy link
Contributor

Added "withholding_tax_in_print" boolean to manage whether withholding tax is added to the printed invoice.
Extended print templates to print withholding_tax_amount, amount_net_pay and (only in invoice printed with payment) amount_net_pay_residual.

Aggiunto un campo booleano "withholding_tax_in_print" che controlla se la ritenuta d'acconto deve essere mostrata nella fattura stampata in pdf. Estesi template di stampa per mostrare i campi withholding_tax_amount, amount_net_pay e (solo sulla stampa con pagamenti) amount_net_pay_residual.

Descrizione del problema o della funzionalità:
See #1504
Comportamento attuale prima di questa PR:

Comportamento desiderato dopo questa PR:
See #2185

@eLBati eLBati mentioned this pull request Mar 31, 2021
4 tasks
@eLBati
Copy link
Member

eLBati commented Apr 8, 2021

@aleuffre grazie.
A differenza della versione per la 11 #1543 vedo che non mostri invoice_line_tax_wt_ids. Pensi sia superfluo?
cc @GSLabIt

@eLBati
Copy link
Member

eLBati commented Apr 8, 2021

Ah il commit 34c80e0 è fatto probabilmente con un email che github non riconosce. Potresti associare l'email all'account github? Oppure modificare l'email del commit

Copy link
Contributor

@GSLabIt GSLabIt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Non sono sicuro che invoice_line_tax_wt_ids sia necessario. Qualcuno ha idee in proposito?

@eLBati
Copy link
Member

eLBati commented Apr 11, 2021

Secondo me non è necessario, dovrebbe essere sufficiente mostrare ritenuta applicata e netto a pagare

@aleuffre
Copy link
Contributor Author

Ciao, grazie mille per le indicazioni!
(Sto appena iniziando a contribuire e alcune cose ancora non mi sono chiare, quindi grazie della pazienza.)

Ho aggiunto invoice_line_tax_wt_ids come suggerito, in maniera simile a quella del commit 11.0; inoltre ho aggiunto a Github l'email usata nei commit.

@aleuffre
Copy link
Contributor Author

L'altra PR è stata mergiata. Cosa posso fare per far andare avanti questa?

@eLBati
Copy link
Member

eLBati commented May 24, 2021

@aleuffre dovresti fare un rebase su OCA:12.0. Sai come?

Added withholding_tax_in_print boolean to manage whether withholding tax is added to the printed invoice. Extended print template to print withholding_tax_amount, amount_net_pay and amount_net_pay_residual
@aleuffre
Copy link
Contributor Author

Si, spero di averlo fatto correttamente!

Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie

@aleuffre
Copy link
Contributor Author

grazie a te!

@eLBati
Copy link
Member

eLBati commented May 24, 2021

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-2193-by-eLBati-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 24, 2021
Signed-off-by eLBati
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-2193-by-eLBati-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c7f5b88 into OCA:12.0 May 24, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0ba6e95. Thanks a lot for contributing to OCA. ❤️

TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 17, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 20, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 6, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 20, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 3, 2021
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Sep 10, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 17, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 1, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 8, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Oct 21, 2021
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Nov 2, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Nov 10, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Dec 16, 2022
TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 9, 2023
TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 16, 2023
TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 27, 2023
are-agilebg pushed a commit to are-agilebg/l10n-italy that referenced this pull request May 10, 2023
are-agilebg pushed a commit to are-agilebg/l10n-italy that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants