Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14.0 mig l10n it account stamp #2077

Merged
merged 41 commits into from
Apr 9, 2021

Conversation

jado95
Copy link
Contributor

@jado95 jado95 commented Jan 29, 2021

Descrizione del problema o della funzionalità:

Comportamento attuale prima di questa PR:

Comportamento desiderato dopo questa PR:

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@jado95 jado95 force-pushed the 14.0-mig-l10n_it_account_stamp branch 5 times, most recently from 8e517aa to 6a81f94 Compare March 5, 2021 14:05
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Mar 5, 2021
@TheMule71 TheMule71 mentioned this pull request Mar 5, 2021
74 tasks
@jado95 jado95 force-pushed the 14.0-mig-l10n_it_account_stamp branch from 6a81f94 to 0d9c911 Compare March 26, 2021 10:52
Copy link
Member

@SimoRubi SimoRubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Potresti aggiungere un test?

l10n_it_account_stamp/data/data.xml Outdated Show resolved Hide resolved
l10n_it_account_stamp/models/account_move.py Show resolved Hide resolved
l10n_it_account_stamp/models/account_move.py Outdated Show resolved Hide resolved
l10n_it_account_stamp/models/account_move.py Outdated Show resolved Hide resolved
@jado95 jado95 force-pushed the 14.0-mig-l10n_it_account_stamp branch 4 times, most recently from 57bca5b to ef43b7f Compare March 26, 2021 17:19
@jado95
Copy link
Contributor Author

jado95 commented Mar 27, 2021

Grazie della PR!
Potresti aggiungere un test?

Aggiunto, e direi di aver sistemato anche il resto delle cose chieste.

@jado95 jado95 force-pushed the 14.0-mig-l10n_it_account_stamp branch 4 times, most recently from f0035ff to 5fcd1c0 Compare April 2, 2021 14:22
Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go

Copy link

@marcelofrare marcelofrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me! Thanks @jado95

@jado95 jado95 requested a review from SimoRubi April 9, 2021 09:44
Copy link
Member

@SimoRubi SimoRubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie del test!
Alcuni dei problemi che ti segnalai in #2077 (review) ci sono ancora, puoi controllare?

I problemi sulle stringhe non sono bloccanti, sarebbe comunque meglio togliere il 'sss' che hai aggiunto

l10n_it_account_stamp/models/account_move.py Show resolved Hide resolved
l10n_it_account_stamp/models/account_move.py Outdated Show resolved Hide resolved
l10n_it_account_stamp/models/account_move.py Outdated Show resolved Hide resolved
@jado95 jado95 force-pushed the 14.0-mig-l10n_it_account_stamp branch 2 times, most recently from 85b16ae to 12e54e1 Compare April 9, 2021 12:24
@jado95 jado95 requested a review from SimoRubi April 9, 2021 12:25
sergiocorato and others added 2 commits April 9, 2021 15:17
[FIX] clean

[FIX] clean

[FIX] pep8

[IMP] use tax obj instead of tax code

[FIX] icon path

[FIX] get product with lang context

[FIX] translation

[FIX] product name

[FIX] compute after unlink of invoice line
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 17, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 17, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 20, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 20, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 6, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 6, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 20, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 20, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 3, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 3, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 17, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 17, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 1, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 1, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 8, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 8, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 29, 2022
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.