Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] l10n_it_causali_pagamento #1987

Merged
merged 24 commits into from
May 5, 2021
Merged

[14.0][MIG] l10n_it_causali_pagamento #1987

merged 24 commits into from
May 5, 2021

Conversation

TheMule71
Copy link
Contributor

Migrazione dalla 12.0 alla 14.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@TheMule71 TheMule71 mentioned this pull request Jan 15, 2021
Open
74 tasks
andreampiovesana
andreampiovesana approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go

primes2h
primes2h requested changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@primes2h primes2h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao, grazie della PR.
Ho fatto una revisione al volo, ci sono alcune stringhe che andrebbero in inglese perché compaiono nel .pot.

Inoltre vedi anche:
#1938 (comment)

l10n_it_causali_pagamento/views/causali_pagamento_view.xml Outdated Show resolved Hide resolved
l10n_it_causali_pagamento/views/causali_pagamento_view.xml Outdated Show resolved Hide resolved
l10n_it_causali_pagamento/models/causale_pagamento.py Outdated Show resolved Hide resolved
l10n_it_causali_pagamento/views/causali_pagamento_view.xml Outdated Show resolved Hide resolved
l10n_it_causali_pagamento/views/causali_pagamento_view.xml Outdated Show resolved Hide resolved
l10n_it_causali_pagamento/readme/USAGE.rst Outdated Show resolved Hide resolved
l10n_it_causali_pagamento/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
@TheMule71 TheMule71 force-pushed the 14.0-mig-l10n_it_causali_pagamento branch from 72f882d to dbdf008 Compare January 15, 2021 15:50
andreampiovesana
andreampiovesana approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test ok

@tafaRU
Copy link
Member

tafaRU commented Mar 19, 2021

@primes2h ok per cambiare il nome del modulo in inglese: quale?

@andreampiovesana
Copy link
Contributor

da:
l10n_it_causali_pagamento
a:
l10n_it_payment_reason
?

@primes2h
Copy link
Contributor

@primes2h ok per cambiare il nome del modulo in inglese: quale?

Se si vuole mantenere il plurale "causali pagamento" direi l10n_it_payment_reasons altrimenti l10n_it_payment_reason.

@tafaRU
Copy link
Member

tafaRU commented Mar 19, 2021

altrimenti l10n_it_payment_reason.

io voto questa

@OpenCode
Copy link
Contributor

@primes2h ok per cambiare il nome del modulo in inglese: quale?

Se si vuole mantenere il plurale "causali pagamento" direi l10n_it_payment_reasons altrimenti l10n_it_payment_reason.

I moduli dovrebbero avere i nomi al singolare. Voto per l10n_it_payment_reason.

@TheMule71 TheMule71 force-pushed the 14.0-mig-l10n_it_causali_pagamento branch 6 times, most recently from ff1cfe7 to 9a759bb Compare April 2, 2021 09:29
@TheMule71 TheMule71 requested a review from primes2h April 2, 2021 15:30
tafaRU
tafaRU requested changes Apr 9, 2021
View reviewed changes
Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In aggiunta: forse le modifiche al renaming del modulo avrebbe avuto senso lasciarle su un commit separato, non pensi?

l10n_it_payment_reason/tests/test_causali.py Outdated Show resolved Hide resolved
l10n_it_payment_reason/migrations/14.0.1.0.0/pre-migrate.py Outdated Show resolved Hide resolved
l10n_it_payment_reason/models/causale_pagamento.py Outdated Show resolved Hide resolved
@scigghia
Copy link
Contributor

scigghia commented Apr 9, 2021

è più attraente l10n_it_causali_pagamento

@TheMule71 TheMule71 force-pushed the 14.0-mig-l10n_it_causali_pagamento branch 2 times, most recently from 93a67bc to 83a4ede Compare April 9, 2021 09:18
@TheMule71 TheMule71 requested a review from tafaRU April 9, 2021 09:19
tafaRU
tafaRU requested changes Apr 9, 2021
View reviewed changes
l10n_it_payment_reason/data/causali_pagamento_data.xml Outdated Show resolved Hide resolved
l10n_it_payment_reason/models/causale_pagamento.py Outdated Show resolved Hide resolved
l10n_it_payment_reason/models/causale_pagamento.py Outdated Show resolved Hide resolved
l10n_it_payment_reason/views/causali_pagamento_view.xml Outdated Show resolved Hide resolved
l10n_it_payment_reason/tests/test_causali.py Outdated Show resolved Hide resolved
l10n_it_payment_reason/i18n/l10n_it_causali_pagamento.pot Outdated Show resolved Hide resolved
l10n_it_payment_reason/i18n/it.po Outdated Show resolved Hide resolved
@TheMule71 TheMule71 force-pushed the 14.0-mig-l10n_it_causali_pagamento branch from 83a4ede to faf7bc9 Compare April 9, 2021 10:04
@tafaRU
Copy link
Member

tafaRU commented Apr 9, 2021

Controlla anche Travis che è 🔴

@TheMule71
Copy link
Contributor Author

Controlla anche Travis che è

Adesso è verde.

@TheMule71 TheMule71 force-pushed the 14.0-mig-l10n_it_causali_pagamento branch from faf7bc9 to 4512a89 Compare April 9, 2021 10:41
@TheMule71 TheMule71 requested a review from tafaRU April 9, 2021 11:07
tafaRU
tafaRU approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie @TheMule71! Ricordati di notificare quando hai terminato di risolvere i commenti 😉

@tafaRU
Copy link
Member

tafaRU commented Apr 9, 2021

@TheMule71 ignora questo messaggio:
> Ricordati di notificare quando hai terminato di risolvere i commenti wink
Ho visto le notifiche su mail solo dopo!

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at db301c3. Thanks a lot for contributing to OCA. ❤️

TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request May 5, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
e5e2edf 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request May 5, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
e5d8887 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
@TheMule71 TheMule71 deleted the 14.0-mig-l10n_it_causali_pagamento branch May 8, 2021 18:37
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 6, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
cb89d3c 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 18, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
9d066f8 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 18, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
3464a18 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 2, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
e6049ab 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 2, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
175cc3f 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
aea9c7e 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
955e160 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
3d03637 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 9, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
73401e3 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 17, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
af1a193 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 20, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
4cc96d6 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
efb6241 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jul 30, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
a0614f9 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 6, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
886ac7e 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Aug 20, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
10d92c8 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 3, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
9b4c971 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Sep 17, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
8b8aa24 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 1, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
f901f6e 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 8, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
2d4253e 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Oct 15, 2021
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
7979f93 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
e9d1fa8 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to TheMule71/l10n-italy that referenced this pull request Jan 21, 2022
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
af706e2 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
TheMule71 added a commit to odoo-italia/l10n-italy that referenced this pull request Jun 29, 2022
@TheMule71
remove merged OCA#1987 OCA#2195, replace OCA#2200 with OCA#2203, add O…
112b529 
…CA#2151 OCA#2212 OCA#2246 OCA#2238 OCA#2248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primes2h primes2h primes2h approved these changes

@tafaRU tafaRU tafaRU approved these changes

@scigghia scigghia scigghia approved these changes

@andreampiovesana andreampiovesana andreampiovesana approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.