Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14.0 MIG l10n_it_account_tax_kind #1973

Merged
merged 24 commits into from
Apr 6, 2021

Conversation

jado95
Copy link
Contributor

@jado95 jado95 commented Dec 11, 2020

Dipende da #1950

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

OpenCode and others added 22 commits November 27, 2020 16:20
[FIX] Depends for display_name compute field

[ADD] Readme file

[ADD] Italian translation
* [FIX] l10n_it_account_tax_kind: fix README

* [IMP] l10n_it_account_tax_kind: rename file according to the model name

* [ADD] l10n_it_account_tax_kind: add tests
[UPD] Update l10n_it_account_tax_kind.pot
Currently translated at 92.3% (12 of 13 strings)

Translation: l10n-italy-11.0/l10n-italy-11.0-l10n_it_account_tax_kind
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-11-0/l10n-italy-11-0-l10n_it_account_tax_kind/it/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (14 of 14 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_tax_kind
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_tax_kind/it/
@jado95 jado95 mentioned this pull request Dec 11, 2020
74 tasks
@jado95 jado95 force-pushed the 14.0-mig-l10n_it_account_tax_kind branch from 9b09b46 to 1a128ed Compare January 29, 2021 10:19
Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test ok

@tafaRU
Copy link
Member

tafaRU commented Mar 19, 2021

@jado95 tutte le build sono rosse. Travis fallisce perché non trova la dipendenza l10n_it_rea. Puoi fare rebase ora che è mergiata?

Copy link
Contributor

@MarcoCalcagni MarcoCalcagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok testato

Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vedi #1973 (comment)

EDIT: L'errore è dovuto al fatto che al momento della build non era ancora stato mergiata l10n_it_account.

@jado95 jado95 force-pushed the 14.0-mig-l10n_it_account_tax_kind branch from 9943b9c to d5343e4 Compare April 2, 2021 08:19
@jado95
Copy link
Contributor Author

jado95 commented Apr 2, 2021

@tafaRU Merge?

@jado95 jado95 force-pushed the 14.0-mig-l10n_it_account_tax_kind branch 2 times, most recently from a045463 to e0ad6b6 Compare April 2, 2021 09:43
Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ancora qualche piccola correzione di stile nelle traduzioni in italiano 👨‍🏫 poi ci siamo 👍
Grazie!

l10n_it_account_tax_kind/readme/CONFIGURE.rst Outdated Show resolved Hide resolved
l10n_it_account_tax_kind/readme/USAGE.rst Outdated Show resolved Hide resolved
@jado95 jado95 force-pushed the 14.0-mig-l10n_it_account_tax_kind branch 2 times, most recently from 09f18e1 to 6043c42 Compare April 2, 2021 11:58
@jado95 jado95 force-pushed the 14.0-mig-l10n_it_account_tax_kind branch from 6043c42 to 3a00f31 Compare April 2, 2021 12:42
Copy link
Contributor

@primes2h primes2h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao, grazie della PR!
Giusto qualche piccola correzione di stile (rif. linee guida).

l10n_it_account_tax_kind/readme/CONFIGURE.rst Outdated Show resolved Hide resolved
l10n_it_account_tax_kind/readme/CONFIGURE.rst Show resolved Hide resolved
l10n_it_account_tax_kind/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
l10n_it_account_tax_kind/readme/USAGE.rst Outdated Show resolved Hide resolved
@jado95 jado95 force-pushed the 14.0-mig-l10n_it_account_tax_kind branch from 3a00f31 to db0aab9 Compare April 2, 2021 14:02
@jado95 jado95 force-pushed the 14.0-mig-l10n_it_account_tax_kind branch from db0aab9 to 07fc4d5 Compare April 2, 2021 14:06
@jado95 jado95 requested review from primes2h and tafaRU April 2, 2021 15:29
Copy link
Contributor

@MarcoCalcagni MarcoCalcagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personalmente Approvo questa PR .
Per favore siccome siamo ad Aprile ed in enorme ritardo i perfezionamenti curiamoli in un secondo momento. Garantiamo il funzionamento poi a perfezionare traduzioni readme ecc ci sarà tempo e soprattutto non blocchiamo il moduli che dipendono da. Nello specifico lettera maiuscola minuscola può essere una pr successiva.

mergiamo 🙏
Grazie

Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go

@MarcoCalcagni
Copy link
Contributor

MarcoCalcagni commented Apr 2, 2021 via email

@primes2h
Copy link
Contributor

primes2h commented Apr 2, 2021

scusami ma sono incazzato nero.

E questo ti ha portato a non notare che ho approvato la PR più un'ora fa.
Ti faccio anche notare che se non è stata mergiata è perché manca ancora l'ok di @tafaRU che aveva richiesto alcune modifiche.
Ti auguro buona feste e un buon week-end di relax. ❤️

@tafaRU
Copy link
Member

tafaRU commented Apr 6, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1973-by-tafaRU-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cb51017 into OCA:14.0 Apr 6, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b2f777d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.