Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] Migration: l10n_it_fiscal_payment_term #1939

Merged
merged 20 commits into from
Jan 22, 2021

Conversation

Borruso
Copy link
Contributor

@Borruso Borruso commented Nov 6, 2020

Porting del modulo l10n_it_fiscal_payment_term dalla versione 12.0 alla 14.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

sergiocorato and others added 19 commits November 6, 2020 11:51
[FIX] removed untranslated po and change fields name for more general purpose

[FIX] ref to fiscal payment in xml demo

[IMP] add migration script
and openerp XML tag
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (12 of 12 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_fiscal_payment_term
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_fiscal_payment_term/it/
Currently translated at 100.0% (12 of 12 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_fiscal_payment_term
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_fiscal_payment_term/it/
…pa.payment_method or fatturapa.payment_term

Every code is already added by the module and user could ignore the right data to insert
@Borruso Borruso mentioned this pull request Nov 6, 2020
74 tasks
Copy link
Member

@SimoRubi SimoRubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Ho fatto review del codice e provato in locale, mi pare tutto ok.
Ho segnato solo un paio di appunti.

@@ -3,3 +3,4 @@
* Roberto Onnis <[email protected]>
* Alessio Gerace <[email protected]>
* Sergio Zanchetta <https://github.com/primes2h>
* Giuseppe Borruso - Dinamiche Aziendali srl <https://github.com/primes2h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credo che qui tu voglia mettere il link al tuo profilo, non quello di Sergio

# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).

{
"name": "Italian Localization - Termini fiscali di pagamento",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Borruso Borruso force-pushed the 14.0-mig-l10n_it_fiscal_payment_term branch from 7d3c283 to 59d3222 Compare December 4, 2020 16:15
@Borruso Borruso requested a review from SimoRubi December 4, 2020 16:17
Copy link
Member

@SimoRubi SimoRubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie!

Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test e code review 👍

@tafaRU
Copy link
Member

tafaRU commented Jan 22, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1939-by-tafaRU-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 461b7e3 into OCA:14.0 Jan 22, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fc5df32. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants