[14.0] mig l10n_it_rea #1930

jado95 · 2020-10-30T15:16:27Z

Descrizione del problema o della funzionalità:

Comportamento attuale prima di questa PR:

Comportamento desiderato dopo questa PR:

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

[FIX] Add readme [FIX] fix province [FIX] Module name and description [FIX] Fixed Register [FIX] rem descr from __openerp__

FIX bug tracker and empty keys

[MIG] Rename manifest files

[FIX] © -> Copyright, and make module installable [FIX] Enconding on py files [UPD] Readme [FIX] openerp -> odoo in xml tag Add Authors, use https on oca web site

[UPD] Update l10n_it_rea.pot

ADD REA fields to copany and compute company_registry accordingly

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Currently translated at 100.0% (15 of 15 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_rea Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_rea/it/

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Currently translated at 100.0% (15 of 15 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_rea Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_rea/it/

tafaRU · 2020-11-20T10:26:21Z

@jado95 ho forzato il rebuild di runbot: vediamo se diventa 🟢

jado95 · 2020-11-20T10:35:48Z

@tafaRU Ottimo, grazie.

tafaRU · 2020-11-20T10:49:00Z

@jado95 in fase di revisione del codice ho colto l'occasione per apportare questo piccolo improvement: jado95#1 Consiglio di mergiarlo non usando l'opzione Create a merge commit. Grazie.

tafaRU · 2020-11-20T10:55:40Z

@jado95 aspetta a mergiare jado95#1 Ho visto che runbot che è ancora rosso magari sono necessarie ulteriori modifiche.

…d and fix the following warnings that are getting runbot build red. (#1) 2020-11-20 10:30:20,958 160 WARNING openerp_test odoo.fields: res.company.rea_member_type: selection attribute will be ignored as the field is related 2020-11-20 10:30:20,959 160 WARNING openerp_test odoo.fields: res.company.rea_liquidation_state: selection attribute will be ignored as the field is related

robyf70

Per il resto LGTM

robyf70 · 2020-11-20T14:38:25Z

l10n_it_rea/models/res_partner.py

+        [("LS", "In liquidation"), ("LN", "Not in liquidation")], "Liquidation State"
+    )
+
+    _sql_constraints = [


Spesso questi campi non sono valorizzati, perchè non rimuoviamo il constraint?

Non me ne intendo! Se ne sei sicuro, per me ok, altrimenti chiederei prima conferma a @marco-marchiori.

Si ok! Rimane comunque il problema che se una o più aziende non hanno indicato questi dati e dobbiamo creare il contatto, la creazione fallisce perchè il constraint fallisce, io l'ho rimuovo sempre nelle installazioni perchè crea solo problemi e blocca l'import delle fatture elettroniche per i fornitori nuovi

Se i campi sono vuoti, il vincolo non viene violato:
https://www.postgresql.org/docs/current/ddl-constraints.html#DDL-CONSTRAINTS-UNIQUE-CONSTRAINTS

However, two null values are never considered equal in this comparison. That means even in the presence of a unique constraint it is possible to store duplicate rows that contain a null value in at least one of the constrained columns

Quindi non vedo problemi

robyf70

Comunque LGTM! Magari rimuoviamo il constraint dopo

OCA-git-bot · 2020-11-20T15:45:58Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

tafaRU · 2020-11-20T15:46:59Z

Comunque LGTM! Magari rimuoviamo il constraint dopo

Ok, allora mergio!

tafaRU · 2020-11-20T15:47:16Z

/ocabot merge patch

OCA-git-bot · 2020-11-20T15:47:33Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-1930-by-tafaRU-bump-patch, awaiting test results.

Signed-off-by tafaRU

jado95 · 2020-11-20T15:52:19Z

Ottimo!

tafaRU · 2020-11-26T08:05:14Z

Il merge di questa PR è rimasto bloccato per via del problema evidenziato in https://odoo-community.org/groups/contributors-15/contributors-181547
Ho eliminato il branch creato da OCA Bot e provo a rilanciare il merge.

tafaRU · 2020-11-26T08:05:33Z

/ocabot merge patch

OCA-git-bot · 2020-11-26T08:05:47Z

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1930-by-tafaRU-bump-patch, awaiting test results.

OCA-git-bot · 2020-11-26T09:40:19Z

Congratulations, your PR was merged at e8781e0. Thanks a lot for contributing to OCA. ❤️

hurrinico and others added 30 commits October 30, 2020 14:42

[ADD] Add rea to v8

3a316f9

[FIX] Add readme [FIX] fix province [FIX] Module name and description [FIX] Fixed Register [FIX] rem descr from __openerp__

Add bug tracker link on README.rst

9e6c8b2

OCA Transbot updated translations from Transifex

7d9a0fb

[UPD] prefix versions with 8.0

5e3c568

[MIG] Make modules uninstallable

81fdb98

OCA Transbot updated translations from Transifex

39084ba

porting l10n_it_rea to 9.0

c9edc62

FIX bug tracker and empty keys

OCA Transbot updated translations from Transifex

b94d749

[FIX] remove en.po that was erroneously created by transbot

a16b6b7

OCA Transbot updated translations from Transifex

1fc6024

[MIG] Make modules uninstallable

191e870

[MIG] Rename manifest files

OCA Transbot updated translations from Transifex

d9097f4

[MIG] l10n_it_rea: Migrated to 10.0

d98442b

[FIX] © -> Copyright, and make module installable [FIX] Enconding on py files [UPD] Readme [FIX] openerp -> odoo in xml tag Add Authors, use https on oca web site

OCA Transbot updated translations from Transifex

6ce22ec

[UPD] Update l10n_it_rea.pot

[MIG] l10n_it_rea: Migration to 11.0

1bf20fa

FIX REA fields order (OCA#612)

31b16d5

ADD REA fields to copany and compute company_registry accordingly

[UPD] Update l10n_it_rea.pot

678b6f0

porting l10n_it_rea to 12.0

bce8f15

ADD l10n_it_rea tests

91a1225

[UPD] Update l10n_it_rea.pot

54ba3b3

Update translation files

2985ded

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Translated using Weblate (Italian)

5f3dafd

Currently translated at 100.0% (15 of 15 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_rea Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_rea/it/

Translated using Weblate (Italian)

8a7becf

Currently translated at 100.0% (15 of 15 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_rea Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_rea/it/

Translated using Weblate (Italian)

9df4581

Currently translated at 100.0% (15 of 15 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_rea Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_rea/it/

[FIX] l10n_it_rea summary translation and source strings (OCA#732)

36d19db

[UPD] Update l10n_it_rea.pot

71c88a1

[UPD] Update l10n_it_rea.pot

d8191cc

Update translation files

dfa45d2

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Translated using Weblate (Italian)

e5648e5

Currently translated at 100.0% (15 of 15 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_rea Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_rea/it/

Translated using Weblate (Italian)

5c81fc3

Currently translated at 100.0% (15 of 15 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_rea Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_rea/it/

jado95 force-pushed the 14.0-mig-l10n_it_rea branch 2 times, most recently from 02f9dd1 to 79625ce Compare November 4, 2020 11:40

[MIG] l10n_it_rea: Migration to 14.0

fe65145

jado95 force-pushed the 14.0-mig-l10n_it_rea branch from 79625ce to fe65145 Compare November 4, 2020 12:53

tafaRU approved these changes Nov 20, 2020

View reviewed changes

robyf70 reviewed Nov 20, 2020

View reviewed changes

robyf70 approved these changes Nov 20, 2020

View reviewed changes

OCA-git-bot added approved ready to merge labels Nov 20, 2020

OCA-git-bot added a commit that referenced this pull request Nov 20, 2020

Merge PR #1930 into 14.0

7450bdc

Signed-off-by tafaRU

OCA-git-bot added the bot is merging ⏳ label Nov 20, 2020

OCA-git-bot merged commit ea3c39d into OCA:14.0 Nov 26, 2020

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 26, 2020

jado95 deleted the 14.0-mig-l10n_it_rea branch November 27, 2020 09:53

francesco-ooops added the migration label Jan 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0] mig l10n_it_rea #1930

[14.0] mig l10n_it_rea #1930

jado95 commented Oct 30, 2020

tafaRU commented Nov 20, 2020 •

edited

Loading

jado95 commented Nov 20, 2020

tafaRU commented Nov 20, 2020

tafaRU commented Nov 20, 2020

robyf70 left a comment

robyf70 Nov 20, 2020

tafaRU Nov 20, 2020

robyf70 Nov 20, 2020

eLBati Nov 24, 2020

robyf70 left a comment

OCA-git-bot commented Nov 20, 2020

tafaRU commented Nov 20, 2020

tafaRU commented Nov 20, 2020

OCA-git-bot commented Nov 20, 2020

jado95 commented Nov 20, 2020

tafaRU commented Nov 26, 2020

tafaRU commented Nov 26, 2020

OCA-git-bot commented Nov 26, 2020

OCA-git-bot commented Nov 26, 2020

[14.0] mig l10n_it_rea #1930

[14.0] mig l10n_it_rea #1930

Conversation

jado95 commented Oct 30, 2020

tafaRU commented Nov 20, 2020 • edited Loading

jado95 commented Nov 20, 2020

tafaRU commented Nov 20, 2020

tafaRU commented Nov 20, 2020

robyf70 left a comment

Choose a reason for hiding this comment

robyf70 Nov 20, 2020

Choose a reason for hiding this comment

tafaRU Nov 20, 2020

Choose a reason for hiding this comment

robyf70 Nov 20, 2020

Choose a reason for hiding this comment

eLBati Nov 24, 2020

Choose a reason for hiding this comment

robyf70 left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Nov 20, 2020

tafaRU commented Nov 20, 2020

tafaRU commented Nov 20, 2020

OCA-git-bot commented Nov 20, 2020

jado95 commented Nov 20, 2020

tafaRU commented Nov 26, 2020

tafaRU commented Nov 26, 2020

OCA-git-bot commented Nov 26, 2020

OCA-git-bot commented Nov 26, 2020

tafaRU commented Nov 20, 2020 •

edited

Loading