Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mig 12.0 l10n br delivery #967

Merged
merged 116 commits into from
Dec 14, 2020
Merged

Conversation

DiegoParadeda
Copy link
Contributor

No description provided.

@mileo mileo added the blocked label Oct 31, 2020
@DiegoParadeda DiegoParadeda force-pushed the mig-12.0-l10n_br_delivery branch 2 times, most recently from 0ecbac2 to 7fe32fb Compare December 4, 2020 14:45
@mileo mileo marked this pull request as ready for review December 4, 2020 17:16
@mileo
Copy link
Member

mileo commented Dec 4, 2020

@DiegoParadeda favor verificar o problema do runbot

Copy link
Contributor

@luismalta luismalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testado no runbot, aparentemente sem problemas.
Apenas necessário corrigir o warning do runbot:

WARNING openerp_test odoo.addons.base.models.ir_model: Two fields (quantity, product_qty) of sale.order.line() have the same label: Quantity.

Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mileo mileo removed the blocked label Dec 8, 2020
'data': [
],
'demo': [],
'category': 'Localisation',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localization

inverse='_inverse_amount_freight',
)

# def get_delivery_price(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remover

mileo
mileo previously requested changes Dec 8, 2020
Copy link
Member

@mileo mileo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pessoal esse módulo ainda precisa de vários ajustes para ser aprovado, fiz uma revisão rápida e enumero alguns pontos:

  1. Corrigir o manifesto pois tem vários erros;
  2. Criar os arquivos de readme conforme o padrão;
  3. Implementar testes;
  4. Fazer o rateio do seguro e outros custos também.

@gabrielcardoso21 gabrielcardoso21 force-pushed the mig-12.0-l10n_br_delivery branch from f4d6def to b244486 Compare December 8, 2020 13:33
@luismalta luismalta force-pushed the mig-12.0-l10n_br_delivery branch from 48971dc to 583ac61 Compare December 8, 2020 17:45
@luismalta
Copy link
Contributor

Os testes dependem das correções implementadas no PR #842

@gabrielcardoso21 gabrielcardoso21 force-pushed the mig-12.0-l10n_br_delivery branch from ada3043 to cc18bc1 Compare December 9, 2020 18:02
@mileo mileo force-pushed the mig-12.0-l10n_br_delivery branch from cc18bc1 to f85e1af Compare December 9, 2020 20:25
@luismalta
Copy link
Contributor

Depends on PR #1041

…ddons para adicionar na nota fiscal as informações de transporte, adicionado a series de documentos fiscais, e mudado views de vendas e nota fiscal, para mudar a obrigatoriedade dos campos da localização.
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@mileo
Copy link
Member

mileo commented Dec 14, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-967-by-mileo-bump-nobump, awaiting test results.

@mileo
Copy link
Member

mileo commented Dec 14, 2020

Pessoal solicitei o merge desde PR, entretanto tem alguns detalhes que vamos precisar ver mais para frente:

  1. A tabela de veículos foi removida: https://github.com/OCA/l10n-brazil/blob/8.0/l10n_br_delivery/models/l10n_br_delivery.py e precisamos decidir se ela vai ser inserida novamente através dos SPECS da nf-e ou faremos manualmente e sincronizaremos com os specs (Visto que outros documentos fiscais também podem ter frete).

  2. O módulo na versão anterior foi feito pela Akretion: https://github.com/OCA/l10n-brazil/blob/8.0/l10n_br_delivery/__openerp__.py#L8 e ela deve ser adicionada como co-autora.

cc: @renatonlima @rvalyi @gabrielcardoso21 @DiegoParadeda

@OCA-git-bot OCA-git-bot merged commit ce9fc12 into OCA:12.0 Dec 14, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ac5e602. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.