[12.0][FIX] Test l10n_br_sale_stock, field price_unit can be change after Confimed stock.picking. #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing depending of Product Stock Valuation defined.
renatonlima
approved these changes
Jul 21, 2021
rvalyi
approved these changes
Jul 21, 2021
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
This PR has the |
|
Congratulations, your PR was merged at d529cdc. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test l10n_br_sale_stock, field price_unit can be change after Confimed stock.picking depending of Product Stock Valuation defined.
O campo price_unit na stock.move pode ser alterado ao Confirmar/Validar um stock.picking, isso parece acontecer devido a configuração da forma de Valorização de Estoque do Produto, o erro nos testes passou a ocorrer na refatoração do modulo l10n_br_delivery #1301 acredito que devido alteração dessa configuração nos dados de demonstração, talvez seja importante a confirmação do que levou ao erro, porém como esse comportamento é algo esperado que ocorre no core essa diferença também já é esperada ( aqui é possível ver no método a alteração https://github.com/odoo/odoo/blob/12.0/addons/stock_account/models/stock.py#L255 )
cc @renatonlima @rvalyi