Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] hr_employee_digitized_signature: Migration to 16.0 #1187

Merged
merged 13 commits into from
Feb 20, 2023
Merged

[16.0][MIG] hr_employee_digitized_signature: Migration to 16.0 #1187

merged 13 commits into from
Feb 20, 2023

Conversation

jaenbox
Copy link

@jaenbox jaenbox commented Feb 6, 2023

Standard migration to 16.0

newtratip and others added 13 commits February 7, 2023 16:20
@newtratip
[14.0][ADD] hr_employee_digitized_signature
b97b626
@oca-travis
[UPD] Update hr_employee_digitized_signature.pot
fa6f783
@OCA-git-bot
[UPD] README.rst
15cfb7b
@OCA-git-bot
[ADD] icon.png
73f8528
@marylla
Added translation using Weblate (German)
7456157
@marylla
Translated using Weblate (German)
3c83556 
Currently translated at 100.0% (5 of 5 strings)

Translation: hr-14.0/hr-14.0-hr_employee_digitized_signature
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_digitized_signature/de/
@nimarosa
Added translation using Weblate (Spanish (Argentina))
6b2f4d6
@nimarosa
Translated using Weblate (Spanish (Argentina))
edb3353 
Currently translated at 100.0% (5 of 5 strings)

Translation: hr-14.0/hr-14.0-hr_employee_digitized_signature
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_digitized_signature/es_AR/
@TheerayutEncoder
[MIG] hr_employee_digitized_signature: Migration to 15.0
f46ce88
[UPD] Update hr_employee_digitized_signature.pot
6e3e9cc
@OCA-git-bot
[UPD] README.rst
3564d54
[IMP] hr_employee_digitized_signature: pre-commit stuff
eafdd0b
[MIG] hr_employee_digitized_signature: Migration to 16.0
39d5630
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

hieulucky111
hieulucky111 approved these changes Feb 17, 2023
View reviewed changes
Copy link

@hieulucky111 hieulucky111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Code review

Saran440
Saran440 approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test 👍

@Saran440
Copy link
Member

/ocabot migration hr_employee_digitized_signature

@OCA-git-bot
Copy link
Contributor

Hi @Saran440. Your command failed:

Invalid options for command migration: .

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Feb 20, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 20, 2023
Open
24 tasks
nimarosa
nimarosa approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@nimarosa nimarosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Looks okay.

@nimarosa
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1187-by-nimarosa-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8f7b795 into OCA:16.0 Feb 20, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at df16c55. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abranes Abranes Abranes approved these changes

@nimarosa nimarosa nimarosa approved these changes

@hieulucky111 hieulucky111 hieulucky111 approved these changes

@Saran440 Saran440 Saran440 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
10 participants
@jaenbox @OCA-git-bot @Saran440 @nimarosa @Abranes @hieulucky111 @newtratip @oca-travis @marylla @TheerayutEncoder