-
-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] hr_employee_birth_name: migration to 16.0 #1179
[16.0][MIG] hr_employee_birth_name: migration to 16.0 #1179
Conversation
[UPD] Update hr_employee_birth_name.pot
[UPD] Update hr_employee_birth_name.pot Translated using Weblate (Portuguese (Brazil)) Currently translated at 100,0% (2 of 2 strings) Translation: hr-11.0/hr-11.0-hr_employee_birth_name Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_employee_birth_name/pt_BR/
[UPD] Update hr_employee_birth_name.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-12.0/hr-12.0-hr_employee_birth_name Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_birth_name/ Translated using Weblate (German) Currently translated at 100.0% (2 of 2 strings) Translation: hr-12.0/hr-12.0-hr_employee_birth_name Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_birth_name/de/ Translated using Weblate (Spanish) Currently translated at 100.0% (2 of 2 strings) Translation: hr-12.0/hr-12.0-hr_employee_birth_name Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_birth_name/es/ [UPD] README.rst
@pedrobaeza I created this PR for hr_employee_birth_name. |
/ocabot migration hr_employee_birth_name Now you need to find reviewers to this PR, and one being PSC or maintainer. You can review other PRs and ask in exchange that they review yours. |
8dde0e8
to
1ff9ec7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some tiny improvements
@@ -0,0 +1,8 @@ | |||
To install this module, you need to: | |||
|
|||
1. Clone the branch 11.0 of the repository https://github.com/OCA/hr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
11.0 should change now to 16.0
Anyway for me these instructions seems like not needed at all, it's too basic
@@ -0,0 +1,19 @@ | |||
<?xml version="1.0" encoding="utf-8" ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This header in xml files is not longer needed since some versions ago
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, stated already in other PRs done today. Not sure why to bother in changing this anyway. You have to reduce the diff to the minimum of not adding a great value.
|
||
.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
:alt: Try me on Runbot | ||
:target: https://runbot.odoo-community.org/runbot/116/11.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pointing to wrong version, but will be probably auto-corrected when the new README is auto-generated when merging
1ff9ec7
to
ecb9e75
Compare
Hello @BT-anieto Please apply this task to your MR: (You can see this here)
|
ecb9e75
to
9c5dce0
Compare
This migration also needs to include the fix from #1160. |
@vincent-hatakeyama It is included |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM
Why is it always building? |
Probably an error with the tools used. Force pushing might be necessary or more simply, someone should just merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review, no changed 👍
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 7d71c6b. Thanks a lot for contributing to OCA. ❤️ |
No description provided.