Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] hr_employee_birth_name: migration to 16.0 #1179

Merged
merged 10 commits into from
Sep 19, 2023
Merged

[16.0][MIG] hr_employee_birth_name: migration to 16.0 #1179

merged 10 commits into from
Sep 19, 2023

Conversation

BT-anieto
Copy link
Contributor

No description provided.

leemannd and others added 5 commits December 27, 2022 07:43
@leemannd @BT-anieto
Add 10.0 hr_employee_birth_name
c03d589
@sbidoul @BT-anieto
remove obsolete .pot files [ci skip]
c58b60c 
[UPD] Update hr_employee_birth_name.pot
@Trivedi-Vacha-SerpentCS @BT-anieto
[MIG][11.0]hr_employee_birth_name:Migration to 11.0.
48a821b 
[UPD] Update hr_employee_birth_name.pot

Translated using Weblate (Portuguese (Brazil))

Currently translated at 100,0% (2 of 2 strings)

Translation: hr-11.0/hr-11.0-hr_employee_birth_name
Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_employee_birth_name/pt_BR/
@luistorresm @BT-anieto
[MIG] hr_employee_birth_name: Migrated to v12
9c63901 
[UPD] Update hr_employee_birth_name.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-12.0/hr-12.0-hr_employee_birth_name
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_birth_name/

Translated using Weblate (German)

Currently translated at 100.0% (2 of 2 strings)

Translation: hr-12.0/hr-12.0-hr_employee_birth_name
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_birth_name/de/

Translated using Weblate (Spanish)

Currently translated at 100.0% (2 of 2 strings)

Translation: hr-12.0/hr-12.0-hr_employee_birth_name
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_birth_name/es/

[UPD] README.rst
@Chanakya-OSI @BT-anieto
[14.0][FIX] Travis.
e32a94b
@BT-anieto BT-anieto mentioned this pull request Dec 27, 2022
Open
24 tasks
@BT-anieto
Copy link
Contributor Author

@pedrobaeza I created this PR for hr_employee_birth_name.

@pedrobaeza
Copy link
Member

/ocabot migration hr_employee_birth_name

Now you need to find reviewers to this PR, and one being PSC or maintainer. You can review other PRs and ask in exchange that they review yours.

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 27, 2022
@BT-anieto BT-anieto force-pushed the 16.0-mig-hr_employee_birth_name branch from 8dde0e8 to 1ff9ec7 Compare December 27, 2022 09:25
BT-rmartin
BT-rmartin approved these changes Dec 27, 2022
View reviewed changes
Copy link

@BT-rmartin BT-rmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some tiny improvements

hr_employee_birth_name/readme/INSTALL.rst Outdated
@@ -0,0 +1,8 @@
To install this module, you need to:

1. Clone the branch 11.0 of the repository https://github.com/OCA/hr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11.0 should change now to 16.0
Anyway for me these instructions seems like not needed at all, it's too basic

hr_employee_birth_name/views/hr_employee_view.xml
@@ -0,0 +1,19 @@
<?xml version="1.0" encoding="utf-8" ?>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This header in xml files is not longer needed since some versions ago

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza say:
OCA/management-system#471 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, stated already in other PRs done today. Not sure why to bother in changing this anyway. You have to reduce the diff to the minimum of not adding a great value.

hr_employee_birth_name/README.rst

.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/116/11.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointing to wrong version, but will be probably auto-corrected when the new README is auto-generated when merging

@BT-anieto BT-anieto force-pushed the 16.0-mig-hr_employee_birth_name branch from 1ff9ec7 to ecb9e75 Compare December 27, 2022 12:08
@luistorresm
Copy link
Contributor

Hello @BT-anieto

Please apply this task to your MR: (You can see this here)

Squash administrative commits (if any) with the previous commit for reducing commit noise. They are named as "[UPD] README.rst", "[UPD] Update $MODULE.pot", "Update translation files" and similar names, and comes from OCA-git-bot, oca-travis or oca-transbot. IMPORTANT: Don't squash legit translation commits, authored by their translators, with the message "Translated using Weblate (...)".

@BT-anieto BT-anieto force-pushed the 16.0-mig-hr_employee_birth_name branch from ecb9e75 to 9c5dce0 Compare December 29, 2022 06:52
@vincent-hatakeyama
Copy link
Contributor

This migration also needs to include the fix from #1160.

@BT-anieto
Copy link
Contributor Author

@vincent-hatakeyama It is included

remi-filament
remi-filament approved these changes Jun 7, 2023
View reviewed changes
Copy link

@remi-filament remi-filament left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

@BT-anieto
Copy link
Contributor Author

Why is it always building?

@vincent-hatakeyama
Copy link
Contributor

Probably an error with the tools used. Force pushing might be necessary or more simply, someone should just merge this.
@OCA/human-resources-maintainers

Saran440
Saran440 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, no changed 👍

@Saran440
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1179-by-Saran440-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7181c63 into OCA:16.0 Sep 19, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7d71c6b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@FernandoRomera FernandoRomera FernandoRomera left review comments

@BT-rmartin BT-rmartin BT-rmartin approved these changes

@Saran440 Saran440 Saran440 approved these changes

@remi-filament remi-filament remi-filament approved these changes

@yaseentai yaseentai yaseentai approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.