Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] hr_employee_lastnames: Migration to 16.0 #1156

Merged
merged 21 commits into from
Nov 8, 2022

Conversation

luistorresm
Copy link
Contributor

No description provided.

Luis Escobar and others added 19 commits November 7, 2022 16:07
Add module to split the last name in to father's last name and mother's
last name.

This module takes the employee name, splits it into three fields, and
assigns each part of the name according to the `partner_names_order`
parameter when calling the inverse name method
Currently translated at 100.0% (7 of 7 strings)

Translation: hr-14.0/hr-14.0-hr_employee_lastnames
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_lastnames/pt_BR/
Currently translated at 71.4% (5 of 7 strings)

Translation: hr-14.0/hr-14.0-hr_employee_lastnames
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_lastnames/ca/
Starting from 14.0, employee model was split into three models:
- `hr.employee.public`
- `hr.employee.private`
- `hr.employee` (a common model)

When this module was migrated, such  split was not taken into account.

This commit moves fields to the common model, so they don't fail when
read from the public employee model.

Co-Authored-By: Luis González <[email protected]>
Currently translated at 100.0% (8 of 8 strings)

Translation: hr-15.0/hr-15.0-hr_employee_lastnames
Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_lastnames/pt_BR/
@luistorresm luistorresm mentioned this pull request Nov 7, 2022
24 tasks
@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 7, 2022
@nimarosa
Copy link
Contributor

nimarosa commented Nov 7, 2022

/ocabot migration hr_employee_lastnames

Avoid WARNING on inherit to create method:
```
The model odoo.addons.hr_employee_firstname.models.hr_employee is not
overriding the create method in batch
```
Copy link
Contributor

@nimarosa nimarosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@moylop260
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1156-by-moylop260-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c06aa08 into OCA:16.0 Nov 8, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 40b41da. Thanks a lot for contributing to OCA. ❤️

@luistorresm luistorresm deleted the 16.0-hr_employee_lastnames-luist branch November 8, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants