-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][mig] web_view_leaflet_map and web_view_leaflet_map_partner #342
[16.0][mig] web_view_leaflet_map and web_view_leaflet_map_partner #342
Conversation
/ocabot migration web_view_leaflet_map_partner |
/ocabot migration web_view_leaflet_map |
a4d3203
to
3907dbe
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
3907dbe
to
4780b48
Compare
Hello @legalsylvain and thank you for this PR. |
4780b48
to
0e4443e
Compare
hi @PaulGoubert . Nice catch ! Could you test again, and update your review ? thanks ! |
LGTM. Thank you @legalsylvain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional Review OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
/ocabot merge patch |
Sorry @legalsylvain you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
/ocabot rebase |
Sorry @legalsylvain you are not allowed to rebase. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
…om 1.8.0, released on April 18, 2022.)
0e4443e
to
2acc9b3
Compare
Merging due to existing reviews: /ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 22435d1. Thanks a lot for contributing to OCA. ❤️ |
Trivial port of the modules :
web_view_leaflet_map
andweb_view_leaflet_map_partner
mig commit to review : 1e873b6
bump leaflet lib from 1.8.0 , released on April 18, 2022 to 1.9.4, released on May 18, 2023.