-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] - geoengine_base_geolocalize #332
[16.0][MIG] - geoengine_base_geolocalize #332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4a144c3
to
03e1a82
Compare
c61348e
to
d977cbd
Compare
@sbejaoui do you plan to also migrate base_geolocalize_openstreetmap? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Code + functional)
/ocabot migration geoengine_base_geolocalize |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
The modul add a new field 'geo_point' computed from partner_latitue and partner_longitude added by base_geolocalize. The geo_point is rendered in a map on the partner form
[FIX] * _get_geo_path method: fix condition * fix name of class bulk_encoder
…ame as Google Map
Squashed commit of the following: commit 527e215 Author: Lindsay <[email protected]> Date: Tue Jun 2 14:47:52 2020 +0200 fixing typo commit dd9c3ec Author: Lindsay <[email protected]> Date: Tue Jun 2 14:42:47 2020 +0200 fixing pylint travis commit 7899f9b Author: Lindsay <[email protected]> Date: Tue Jun 2 14:05:25 2020 +0200 fix travis flake8 linting commit 039e867 Author: Lindsay <[email protected]> Date: Tue Jun 2 13:54:07 2020 +0200 fix travis pylint commit fcfb09e Author: Lindsay <[email protected]> Date: Tue Jun 2 13:45:09 2020 +0200 fixing travis tests commit ff2b39e Author: Lindsay <[email protected]> Date: Tue Jun 2 12:07:45 2020 +0200 fix import commit cdf43dc Author: Lindsay <[email protected]> Date: Tue Jun 2 11:47:21 2020 +0200 add responses to travis for testing commit 79da0ee Author: Lindsay <[email protected]> Date: Tue Jun 2 11:40:55 2020 +0200 disable pylint warning W0622 commit d6eab49 Author: Lindsay <[email protected]> Date: Tue Jun 2 10:29:58 2020 +0200 formatting for linters
d977cbd
to
a6d2c42
Compare
@IT-Ideas Thank you for reminder.... this PR has disappeared from my radar. I took the liberty to rebase it and I'll merge-it. |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 9a574c1. Thanks a lot for contributing to OCA. ❤️ |
needs: