Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] - geoengine_base_geolocalize #332

Merged
merged 22 commits into from
Nov 13, 2023

Conversation

sbejaoui
Copy link
Contributor

@sbejaoui sbejaoui commented Mar 6, 2023

Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbejaoui This PR is missing #155 and is very important to split addons and implement inverse on the latitude and longitude

@sbejaoui sbejaoui force-pushed the 16.0-geoengine_base_geolocalize-sbj branch 3 times, most recently from 4a144c3 to 03e1a82 Compare March 7, 2023 10:01
@sbejaoui sbejaoui requested review from lmignon and removed request for lmignon March 7, 2023 10:01
@sbejaoui sbejaoui force-pushed the 16.0-geoengine_base_geolocalize-sbj branch 5 times, most recently from c61348e to d977cbd Compare March 7, 2023 13:59
@lmignon
Copy link
Contributor

lmignon commented Mar 13, 2023

@sbejaoui do you plan to also migrate base_geolocalize_openstreetmap?

Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code + functional)

@yvaucher
Copy link
Member

/ocabot migration geoengine_base_geolocalize

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 11, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request May 11, 2023
6 tasks
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 1, 2023
@github-actions github-actions bot closed this Nov 5, 2023
@IT-Ideas
Copy link

@lmignon , @sbejaoui The PR is closed. Does it still need review?
LGTM. I am just unsure we need to update the Odoo server version in the .pot file.

@lmignon lmignon added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Nov 13, 2023
@lmignon lmignon reopened this Nov 13, 2023
lmignon and others added 16 commits November 13, 2023 13:48
[FIX]
* _get_geo_path method: fix condition
* fix name of class bulk_encoder
* add a tracker into README.rst
* rename test class
Squashed commit of the following:

commit 527e215
Author: Lindsay <[email protected]>
Date:   Tue Jun 2 14:47:52 2020 +0200

    fixing typo

commit dd9c3ec
Author: Lindsay <[email protected]>
Date:   Tue Jun 2 14:42:47 2020 +0200

    fixing pylint travis

commit 7899f9b
Author: Lindsay <[email protected]>
Date:   Tue Jun 2 14:05:25 2020 +0200

    fix travis flake8 linting

commit 039e867
Author: Lindsay <[email protected]>
Date:   Tue Jun 2 13:54:07 2020 +0200

    fix travis pylint

commit fcfb09e
Author: Lindsay <[email protected]>
Date:   Tue Jun 2 13:45:09 2020 +0200

    fixing travis tests

commit ff2b39e
Author: Lindsay <[email protected]>
Date:   Tue Jun 2 12:07:45 2020 +0200

    fix import

commit cdf43dc
Author: Lindsay <[email protected]>
Date:   Tue Jun 2 11:47:21 2020 +0200

    add responses to travis for testing

commit 79da0ee
Author: Lindsay <[email protected]>
Date:   Tue Jun 2 11:40:55 2020 +0200

    disable pylint warning W0622

commit d6eab49
Author: Lindsay <[email protected]>
Date:   Tue Jun 2 10:29:58 2020 +0200

    formatting for linters
@lmignon lmignon force-pushed the 16.0-geoengine_base_geolocalize-sbj branch from d977cbd to a6d2c42 Compare November 13, 2023 12:50
@lmignon
Copy link
Contributor

lmignon commented Nov 13, 2023

@IT-Ideas Thank you for reminder.... this PR has disappeared from my radar. I took the liberty to rebase it and I'll merge-it.

@lmignon
Copy link
Contributor

lmignon commented Nov 13, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-332-by-lmignon-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit da5621d into OCA:16.0 Nov 13, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9a574c1. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-geoengine_base_geolocalize-sbj branch November 13, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged 🎉 no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.