Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] fieldservice_account_analytic #763

Merged
merged 19 commits into from
Jul 7, 2021

Conversation

Freni-OSI
Copy link
Contributor

No description provided.

@AmmarOfficewalaSerpentCS
Copy link
Contributor

@brian10048 , @patrickrwilson , @dreispt , @osi-scampbell , @smangukiya , @murtuzasaleh
This module dependency module was merged can we rebuild Travis and run bot and review this PR

@patrickrwilson
Copy link
Contributor

@Freni-OSI can you please squash all the automated commits ([UPD], Translations, .pot).

brian10048 and others added 4 commits July 6, 2021 11:21
- This change removes most of the invoicing logic from fieldservice_account and puts it into its own module
@Freni-OSI Freni-OSI force-pushed the 14_fieldservice_account_analytic branch from e0362eb to 1c3d7d0 Compare July 6, 2021 05:51
@Freni-OSI Freni-OSI force-pushed the 14_fieldservice_account_analytic branch from 1c3d7d0 to bab35d8 Compare July 6, 2021 10:06
@Freni-OSI
Copy link
Contributor Author

@Freni-OSI can you please squash all the automated commits ([UPD], Translations, .pot).

Done. needs review. @patrickrwilson

@Freni-OSI Freni-OSI force-pushed the 14_fieldservice_account_analytic branch from bab35d8 to c339d67 Compare July 6, 2021 12:11
@patrickrwilson
Copy link
Contributor

@Freni-OSI can you increase code coverage tests?

@Freni-OSI Freni-OSI force-pushed the 14_fieldservice_account_analytic branch 2 times, most recently from 4cd3b0c to ad23b2b Compare July 7, 2021 07:47
@Freni-OSI Freni-OSI force-pushed the 14_fieldservice_account_analytic branch from ad23b2b to c5b611a Compare July 7, 2021 09:28
Copy link
Contributor

@patrickrwilson patrickrwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as intended. LGTM

@smangukiya
Copy link

@OCA-git-bot merge nobump

@smangukiya smangukiya merged commit 11b6025 into OCA:14.0 Jul 7, 2021
@smangukiya smangukiya deleted the 14_fieldservice_account_analytic branch July 7, 2021 23:06
@smangukiya smangukiya restored the 14_fieldservice_account_analytic branch July 26, 2021 16:37
@smangukiya
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-763-by-smangukiya-bump-nobump, awaiting test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants