Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0] [ADD] fieldservice_sale_agreement #1275

Merged
merged 1 commit into from
Jan 21, 2025
Merged

[17.0] [ADD] fieldservice_sale_agreement #1275

merged 1 commit into from
Jan 21, 2025

Conversation

ivantodorovich
Copy link

Integrates the Field Service and Sale Agreements modules, to:

  • Propagate the agreement_id field from the Sales Order to the FSM Order

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@max3903 max3903 added this to the 17.0 milestone Jan 3, 2025
@ivantodorovich
Copy link
Author

@OCA/field-service-maintainers ok to merge?

@max3903
Copy link
Member

max3903 commented Jan 21, 2025

@ivantodorovich ok for me

hparfr
hparfr approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1275-by-hparfr-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 21, 2025
@OCA-git-bot
Merge PR #1275 into 17.0
f54a59f 
Signed-off-by hparfr
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-1275-by-hparfr-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 134c11f into OCA:17.0 Jan 21, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fbd4954. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yankinmax yankinmax yankinmax approved these changes

@hparfr hparfr hparfr approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@max3903 max3903 max3903 approved these changes

Assignees
No one assigned
Labels
approved enhancement merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ivantodorovich @OCA-git-bot @max3903 @marcelsavegnago @hparfr @yankinmax