Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] fieldservice: Search by name. #1270

Merged

Conversation

DorianMAG
Copy link

Remove str method in xml search filter_domain

@OCA-git-bot
Copy link
Contributor

Hi @brian10048, @max3903,
some modules you are maintaining are being modified, check this out!

@DorianMAG DorianMAG changed the title [17.0][FIX] Fieldservice: Search by name. [17.0][FIX] fieldservice: Search by name. Nov 27, 2024
Remove str method in xml search filter_domain
@DorianMAG DorianMAG force-pushed the 17.0-fix-fieldservice-search_by_name branch from d96032c to cb36421 Compare November 27, 2024 11:18
@max3903 max3903 added this to the 17.0 milestone Nov 27, 2024
@max3903 max3903 self-assigned this Nov 27, 2024
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if I undestand the syntxa, I thinks it's useless
IMHO ('name', 'ilike', self ) should be enough
could you please give you POV @ilo @max3903 ?
Regards

Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @max3903 approve I have no technical comments on this one

Copy link

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @flotho , that leaf seems useless and could be removed IMO.
In any case, the explicit str casting wasn't needed neither

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@max3903
Copy link
Member

max3903 commented Jan 7, 2025

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1270-by-max3903-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@max3903 The merge process could not be finalized, because command git push origin 17.0-ocabot-merge-pr-1270-by-max3903-bump-minor:17.0 failed with output:

To https://github.com/OCA/field-service
 ! [remote rejected]   17.0-ocabot-merge-pr-1270-by-max3903-bump-minor -> 17.0 (cannot lock ref 'refs/heads/17.0': is at 1e959d239bd1ba5c57004cd47ef392fd771b95e2 but expected 2b8e51afacbffbed361cc92e1fb2fb5a513f57f0)
error: failed to push some refs to 'https://github.com/OCA/field-service'

@OCA-git-bot OCA-git-bot merged commit 36647e7 into OCA:17.0 Jan 7, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1e959d2. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants