[17.0][MIG] event_registration_partner_unique: Migration to version 17.0 #390
Conversation
juanjosesegui-tecnativa
changed the title
|
Please check the red CIs, as the module doesn't even install. |
|
The module depends on partner_event, I suspect it does not install because partner_event is not in version 17.0 of OCA. |
|
You're suspicions are funded 😄 push the migration of |
|
/ocabot migration event_registration_partner_unique If this depends in another PR, you can do: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29 |
|
And always put in the main comment such dependency: |
juanjosesegui-tecnativa
force-pushed
the
17.0-mig-event_registration_partner_unique
branch
2 times, most recently
from
08ec984
to
2b32d7d
Compare
|
You have ignored this part of the guide:
|
juanjosesegui-tecnativa
force-pushed
the
17.0-mig-event_registration_partner_unique
branch
2 times, most recently
from
153a5d9
to
0c78ca4
Compare
|
ping @pedrobaeza @chienandalu |
| @@ -3,11 +3,12 @@ | |||
| # Copyright 2018 Tecnativa - Cristina Martin R. | |||
| # Copyright 2020 Tecnativa - Víctor Martínez | |||
| # Copyright 2023 Tecnativa - Carolina Fernandez | |||
| # Copyright 2024 Tecnativa - Juan José Seguí Borja | |||
There was a problem hiding this comment.
Normally for such small migration changes, better put yourself in the contributors.md file
| @@ -10,7 +10,7 @@ | |||
| <field name="priority" eval="99" /> | |||
| <field name="inherit_id" ref="event.view_event_form" /> | |||
| <field name="arch" type="xml"> | |||
| <xpath expr="//field[@name='auto_confirm']" position="after"> | |||
| <xpath expr="//field[@name='badge_image']" position="after"> | |||
There was a problem hiding this comment.
It makes more sense after this one
<xpath expr="//field[@name='create_partner']" position="after">
0c78ca4
to
65d843d
Compare
juanjosesegui-tecnativa
force-pushed
the
17.0-mig-event_registration_partner_unique
branch
from
65d843d
to
05a1a2b
Compare
|
plase review @carolinafernandez-tecnativa |
|
Please Squash administrative commits. Check https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate for details. |
juanjosesegui-tecnativa
force-pushed
the
17.0-mig-event_registration_partner_unique
branch
from
05a1a2b
to
6db241f
Compare
|
Please check again I still seing administrative commits and pre-commit auto fixes for migration is missing. |
juanjosesegui-tecnativa
force-pushed
the
17.0-mig-event_registration_partner_unique
branch
3 times, most recently
from
d55cdde
to
c3d8bed
Compare
|
Administrative commits OK Check please this commit [MIG] event_registration_partner_unique: Migration to 17.0 is empty |
juanjosesegui-tecnativa
force-pushed
the
17.0-mig-event_registration_partner_unique
branch
from
c3d8bed
to
acad67d
Compare
Currently translated at 100.0% (5 of 5 strings) Translation: event-13.0/event-13.0-event_registration_partner_unique Translate-URL: https://translation.odoo-community.org/projects/event-13-0/event-13-0-event_registration_partner_unique/es/
Steps to reproduce the problem: - Register anonymously a first attendee for an event from website. - The registration is saved with no attendee_partner_id. - Repeat the registration again anonymously. - You get the error "Duplicated partners found in event...". That's because current duplicated domain is searching for other registrations regardless of if there's a linked partner or not. We now restrict the search to those with a linked partner. TT32961
juanjosesegui-tecnativa
force-pushed
the
17.0-mig-event_registration_partner_unique
branch
from
acad67d
to
9c3a944
Compare
|
Please Squash administrative commits. There are still some from translation that should be removed. Check https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate for details. |
juanjosesegui-tecnativa
force-pushed
the
17.0-mig-event_registration_partner_unique
branch
from
9c3a944
to
09158e8
Compare
|
This PR has the |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at c6b0710. Thanks a lot for contributing to OCA. ❤️ |
@Tecnativa TT49912
Depends on: