Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] event_registration_multi_qty: Migration to version 16.0 #318

Merged
merged 14 commits into from
Jul 4, 2023

Conversation

stefan-tecnativa
Copy link
Contributor

cc @Tecnativa TT43666

@chienandalu please review!

sergio-teruel and others added 13 commits June 19, 2023 09:39
Currently translated at 100.0% (7 of 7 strings)

Translation: event-10.0/event-10.0-event_registration_multi_qty
Translate-URL: https://translation.odoo-community.org/projects/event-10-0/event-10-0-event_registration_multi_qty/es/
After odoo/odoo@a4d50b4, the passed value is not taken into account when a default value is set on the field.
This adds the option of passing the desired value through the context and force that update.
If we force the multi qty mode by default there's a high chance to come
across unexpected CI errors.
Currently translated at 66.6% (6 of 9 strings)

Translation: event-14.0/event-14.0-event_registration_multi_qty
Translate-URL: https://translation.odoo-community.org/projects/event-14-0/event-14-0-event_registration_multi_qty/it/
@stefan-tecnativa stefan-tecnativa force-pushed the 16.0-mig-event_registration_multi_qty branch from cb77041 to c69200a Compare June 19, 2023 08:40
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test and code review 👍 . Tiny suggestion:

event_registration_multi_qty/models/event.py Outdated Show resolved Hide resolved
@chienandalu
Copy link
Member

please review @CarlosRoca13

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jul 4, 2023
@pedrobaeza
Copy link
Member

/ocabot migration event_registration_multi_qty
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-318-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jun 26, 2023
15 tasks
@OCA-git-bot OCA-git-bot merged commit 0415ae7 into OCA:16.0 Jul 4, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e091ca8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants