Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX + IMP] pdf helper: Fix multi-attachments + Add pdf_embed_xml #898

Merged
merged 3 commits into from
Feb 5, 2024
Merged

[16.0][FIX + IMP] pdf helper: Fix multi-attachments + Add pdf_embed_xml #898

merged 3 commits into from
Feb 5, 2024

Conversation

jbaudoux
Copy link
Contributor

@jbaudoux jbaudoux commented Dec 22, 2023 •
edited
Loading

  • Extraction of the xml file was failing when there are multi attachments in the PDF. Replaced parser code by odoo.tools.pdf and only return XML data
  • Add a new helper to easily embed an attachment in a PDF.
  • base_ubl: use new pdf.helper.pdf_embed_xml
    • Mark _ubl_add_xml_in_pdf_buffer as deprecated
    • Mark _embed_ubl_xml_in_pdf_content as deprecated

@OCA-git-bot
Copy link
Contributor

Hi @simahawk, @alexis-via,
some modules you are maintaining are being modified, check this out!

@jbaudoux jbaudoux force-pushed the 16.0-imp-pdf_helper branch 5 times, most recently from 10fa05a to 19ed078 Compare December 22, 2023 16:08
@jbaudoux
[FIX] pdf_helper: multi-attachments
0329fc5 
Replace code by odoo.tools.pdf
@jbaudoux jbaudoux force-pushed the 16.0-imp-pdf_helper branch from 19ed078 to 99e0d44 Compare December 22, 2023 16:27
@jbaudoux jbaudoux force-pushed the 16.0-imp-pdf_helper branch 3 times, most recently from 6647981 to 22de077 Compare December 22, 2023 17:19
@jbaudoux
[IMP] base_ubl: use pdf.helper.pdf_embed_xml
9a90063 
Mark _ubl_add_xml_in_pdf_buffer as deprecated
Mark _embed_ubl_xml_in_pdf_content
@jbaudoux jbaudoux force-pushed the 16.0-imp-pdf_helper branch from 22de077 to 9a90063 Compare December 22, 2023 17:25
@jbaudoux jbaudoux mentioned this pull request Dec 26, 2023
Open
bosd
bosd approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@bosd bosd mentioned this pull request Dec 30, 2023
Closed
bofiltd
bofiltd approved these changes Jan 10, 2024
View reviewed changes
Copy link

@bofiltd bofiltd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@nguyenminhchien nguyenminhchien mentioned this pull request Jan 23, 2024
Merged
Dranyel-Bosd
Dranyel-Bosd approved these changes Feb 5, 2024
View reviewed changes
Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

simahawk
simahawk approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@simahawk
Copy link
Contributor

simahawk commented Feb 5, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-898-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2c3e966 into OCA:16.0 Feb 5, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cdf8209. Thanks a lot for contributing to OCA. ❤️

This was referenced Feb 5, 2024
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dranyel-Bosd Dranyel-Bosd Dranyel-Bosd approved these changes

@bofiltd bofiltd bofiltd approved these changes

@bosd bosd bosd approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jbaudoux @OCA-git-bot @simahawk @bosd @bofiltd @Dranyel-Bosd