Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] base_edifact: add support for create segment and interchange based on pydifact library #853

Merged
merged 2 commits into from
Nov 13, 2023
Merged

[16.0][IMP] base_edifact: add support for create segment and interchange based on pydifact library #853

merged 2 commits into from
Nov 13, 2023

Conversation

thienvh332
Copy link
Contributor

No description provided.

@thienvh332 thienvh332 marked this pull request as draft November 7, 2023 03:12
@thienvh332 thienvh332 mentioned this pull request Nov 7, 2023
Merged
@thienvh332 thienvh332 force-pushed the 16.0-imp-base_edifact branch from cde118e to d305351 Compare November 7, 2023 03:52
@thienvh332 thienvh332 marked this pull request as ready for review November 7, 2023 04:07
@OCA-git-bot
Copy link
Contributor

Hi @rmorant,
some modules you are maintaining are being modified, check this out!

@QuocDuong1306 QuocDuong1306 mentioned this pull request Nov 8, 2023
Closed
simahawk
simahawk approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, pre-approving

base_edifact/models/edifact.py Outdated Show resolved Hide resolved
base_edifact/models/edifact.py Show resolved Hide resolved
@thienvh332 thienvh332 force-pushed the 16.0-imp-base_edifact branch from d305351 to 6f0fafd Compare November 9, 2023 10:34
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

simahawk
simahawk approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@simahawk
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-853-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3171b39 into OCA:16.0 Nov 13, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fa31f50. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmorant rmorant rmorant approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thienvh332 @OCA-git-bot @simahawk @rmorant