Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] edi_endpoint: cross worker fix #633

Closed
wants to merge 2 commits into from
Closed

[14.0] edi_endpoint: cross worker fix #633

wants to merge 2 commits into from

Conversation

simahawk
Copy link
Contributor

@simahawk simahawk commented Jul 27, 2022 •
edited
Loading

Former version of endpoint_route_handler had a major flaw:

routing rule registry was not properly shared across workers
forcing us to restart the instance to make sure all envs were inline w/ it.

This change adapts edi_endpoint_oca to the new version which contains
some refactoring.

Depends on:

This was referenced Jul 27, 2022
Closed
Merged
@simahawk simahawk changed the title 14 endpoint handler cross worker [14.0] endpoint_route_handler: cross worker fix Jul 27, 2022
@simahawk simahawk changed the title [14.0] endpoint_route_handler: cross worker fix [14.0] edi_endpoint: cross worker fix Jul 27, 2022
@simahawk simahawk force-pushed the 14-endpoint-handler-cross-worker branch from 8983843 to 9ef832f Compare August 9, 2022 07:34
simahawk added a commit to camptocamp/edi that referenced this pull request Aug 12, 2022
@simahawk
edi_endpoint_oca: temp fix for tests
89f5852 
I don't know why but sometimes when test_edi_endpoint
runs before these tests the controller lookup fails.
Since the whole routing registry machinery is going to be refactored
in OCA#633
let's survive w/ this forced registration for now.
simahawk added a commit to camptocamp/edi that referenced this pull request Aug 12, 2022
@simahawk
edi_endpoint_oca: temp fix for tests
d8c914d 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA#633
let's survive w/ this forced registration for now.
simahawk added a commit to camptocamp/edi that referenced this pull request Aug 14, 2022
@simahawk
edi_endpoint_oca: temp fix for tests
9c18d40 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA#633
let's survive w/ this forced registration for now.
simahawk added a commit to simahawk/edi that referenced this pull request Aug 14, 2022
@simahawk
edi_endpoint_oca: temp fix for tests
36454bd 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA#633
let's survive w/ this forced registration for now.
simahawk added a commit to camptocamp/edi that referenced this pull request Aug 14, 2022
@simahawk
edi_endpoint: temp fix for tests
5118196 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA#633
let's survive w/ this forced registration for now.
simahawk added a commit to camptocamp/edi that referenced this pull request Aug 19, 2022
@simahawk
edi_endpoint: temp fix for tests
ec689fb 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA#633
let's survive w/ this forced registration for now.
@simahawk
edi_endpoint: integrate e_route_handler xworker fix
99ec6d7 
Former version of `endpoint_route_handler` had a major flaw:

routing rule registry was not properly shared across workers
forcing us to restart the instance to make sure all envs were inline w/
it.

This change adapts edi_endpoint_oca to the new version which contains
some refactoring.
@simahawk
Add TMP test dep
031bd77
@simahawk simahawk force-pushed the 14-endpoint-handler-cross-worker branch from 9ef832f to 031bd77 Compare August 22, 2022 13:57
TDu pushed a commit to camptocamp/edi that referenced this pull request Sep 28, 2022
@simahawk @TDu
edi_endpoint: temp fix for tests
69b6876 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA#633
let's survive w/ this forced registration for now.
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 22, 2023
@github-actions github-actions bot closed this Feb 26, 2023
@simahawk simahawk mentioned this pull request Mar 1, 2023
Merged
1 task
rjocoleman pushed a commit to etailer/edi that referenced this pull request Mar 22, 2023
@simahawk @rjocoleman
edi_endpoint: temp fix for tests
2e24ea4 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA#633
let's survive w/ this forced registration for now.
JordiBForgeFlow pushed a commit to ForgeFlow/edi-framework that referenced this pull request Jun 9, 2023
@simahawk @JordiBForgeFlow
edi_endpoint: temp fix for tests
fc60f25 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA/edi#633
let's survive w/ this forced registration for now.
LoisRForgeFlow pushed a commit to ForgeFlow/edi-framework that referenced this pull request Oct 4, 2023
@simahawk @LoisRForgeFlow
edi_endpoint: temp fix for tests
cafc4be 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA/edi#633
let's survive w/ this forced registration for now.
simahawk added a commit to OCA/edi-framework that referenced this pull request Dec 18, 2023
@simahawk
edi_endpoint: temp fix for tests
182d36e 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA/edi#633
let's survive w/ this forced registration for now.
tuantrantg pushed a commit to tuantrantg/edi-framework that referenced this pull request Jan 15, 2024
@simahawk @tuantrantg
edi_endpoint: temp fix for tests
50ae77b 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA/edi#633
let's survive w/ this forced registration for now.
simahawk added a commit to OCA/edi-framework that referenced this pull request Jan 31, 2024
@simahawk
edi_endpoint: temp fix for tests
6f28d2f 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA/edi#633
let's survive w/ this forced registration for now.
GuillemCForgeFlow pushed a commit to ForgeFlow/edi that referenced this pull request Oct 29, 2024
@simahawk @GuillemCForgeFlow
edi_endpoint: temp fix for tests
3af28f1 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA#633
let's survive w/ this forced registration for now.
GuillemCForgeFlow pushed a commit to ForgeFlow/edi that referenced this pull request Oct 29, 2024
@simahawk @GuillemCForgeFlow
edi_endpoint: temp fix for tests
e35c04b 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA#633
let's survive w/ this forced registration for now.
GuillemCForgeFlow pushed a commit to ForgeFlow/edi that referenced this pull request Nov 7, 2024
@simahawk @GuillemCForgeFlow
edi_endpoint: temp fix for tests
7032abd 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA#633
let's survive w/ this forced registration for now.
GuillemCForgeFlow pushed a commit to ForgeFlow/edi that referenced this pull request Nov 7, 2024
@simahawk @GuillemCForgeFlow
edi_endpoint: temp fix for tests
c916530 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA#633
let's survive w/ this forced registration for now.
JordiMForgeFlow pushed a commit to ForgeFlow/edi that referenced this pull request Nov 22, 2024
@simahawk @JordiMForgeFlow
edi_endpoint: temp fix for tests
52bbfaa 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA#633
let's survive w/ this forced registration for now.
SilvioC2C pushed a commit to camptocamp/edi-framework that referenced this pull request Dec 3, 2024
@simahawk @SilvioC2C
edi_endpoint: temp fix for tests
7ec0762 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA/edi#633
let's survive w/ this forced registration for now.
JordiMForgeFlow pushed a commit to ForgeFlow/edi-framework that referenced this pull request Dec 17, 2024
@simahawk @JordiMForgeFlow
edi_endpoint: temp fix for tests
5279dc3 
I don't know why but  when test_edi_endpoint runs before these tests
the rollback of the exception catched within the test `test_archive_check`
make the controller lookup fail.
Since the whole routing registry machinery is going to be refactored
in OCA/edi#633
let's survive w/ this forced registration for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@simahawk