[14.0][IMP] product_import: Import products asynchronously #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florentx
force-pushed
the
product_import_job
branch
6 times, most recently
from
96ad6db to
4f485a1
Compare
simahawk
requested changes
Dec 3, 2024
florentx
force-pushed
the
product_import_job
branch
from
4f485a1 to
2a26180
Compare
florentx
force-pushed
the
product_import_job
branch
2 times, most recently
from
9bed83c to
967c912
Compare
florentx
force-pushed
the
product_import_job
branch
2 times, most recently
from
a6f4537 to
c246786
Compare
florentx
force-pushed
the
product_import_job
branch
from
c246786 to
1df34b7
Compare
simahawk
reviewed
Dec 10, 2024
| @@ -13,9 +13,12 @@ | |||
| "stock", | |||
| # OCA/edi | |||
| "base_business_document_import", | |||
| # OCA/queue | |||
| "queue_job", | |||
There was a problem hiding this comment.
I've thought again about this... We should remove this dependency IMO.
In the simplest case we won't need it, in the more complex case we'll probably use the framework. Then, we can leverage the framework to the split.
Additionally, there's now a new feature in queue_job which is called split and allows to.... split items in batches.
See OCA/queue#658
| if products[-1] is None: | ||
| products = [product for product in products if product] | ||
| # One job for x products (chunk of 40) | ||
| wiz.with_delay()._create_update_products(products, seller.id) |
There was a problem hiding this comment.
here I would simply call wiz.create_update_products that will call _create_update_products which can be overridden or you can rely on https://github.com/OCA/queue/blob/16.0/queue_job/models/base.py#L145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some catalogs contain 10'000 references and import does not complete due to other tasks running at the same time, and locking table.
Splitting product import into individual jobs should mitigate this issue.