Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] edi_sale_edifact_oca #32

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

QuocDuong1306
Copy link
Contributor

@QuocDuong1306 QuocDuong1306 commented Oct 19, 2023

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIS this is more a module for testing the integration rather than providing features, right?

edi_sale_edifact_oca/__manifest__.py Outdated Show resolved Hide resolved
@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-add-edi_sale_edifact_oca branch from 866430c to bd847e2 Compare October 25, 2023 01:41
@QuocDuong1306
Copy link
Contributor Author

AFAIS this is more a module for testing the integration rather than providing features, right?

Yes @simahawk , btw I updated the file __manifest__.py

@QuocDuong1306 QuocDuong1306 marked this pull request as draft October 26, 2023 01:57
@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-add-edi_sale_edifact_oca branch from bd847e2 to 6b778a3 Compare October 26, 2023 03:23
@QuocDuong1306 QuocDuong1306 marked this pull request as ready for review October 26, 2023 03:24
@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-add-edi_sale_edifact_oca branch 2 times, most recently from b291892 to 04b4148 Compare October 26, 2023 04:59
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall

@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-add-edi_sale_edifact_oca branch from 04b4148 to c0ac1aa Compare November 21, 2023 10:16
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving

{
"name": "EDI Sales EDIFACT",
"summary": """
Provide a demo exchange type setting for EDIFACT standard in EDI on sales.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and common tests

@@ -0,0 +1 @@
This module provides a demo exchange type setting for EDIFACT standard.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This module provides a demo exchange type setting for EDIFACT standard.
This module provides an example on how to configure and exchange type for EDIFACT standard,
as well as some test coverage for importing orders with the same standard.

@@ -0,0 +1 @@
* Duong (Tran Quoc) <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Duong (Tran Quoc) <[email protected]>
* Duong (Tran Quoc) <[email protected]>
* Simone Orsi <[email protected]>

@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-add-edi_sale_edifact_oca branch from c0ac1aa to fa9db1a Compare November 30, 2023 09:59
@QuocDuong1306
Copy link
Contributor Author

thank @simahawk , I updated

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-32-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 18fd501 into OCA:16.0 Nov 30, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8ecaad3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants