Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] edi_oca: consider parent record when checking access rule #109

Merged
merged 1 commit into from
Nov 28, 2024
Merged

[16.0][FIX] edi_oca: consider parent record when checking access rule #109

merged 1 commit into from
Nov 28, 2024

Conversation

JordiMForgeFlow
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow commented Sep 25, 2024 •
edited
Loading

This fix prevents an error raised when you have child exchanges that do not have a specific model and res_id assigned.

When getting the related record of a child we are already looking at the parent if the exchange record does not have a specific model set (

edi-framework/edi_oca/models/edi_exchange_record.py

Line 210 in d484f0d

if not self.model and self.parent_id:
). The same should be done when checking the access.

@OCA-git-bot
Copy link
Contributor

Hi @etobella, @simahawk,
some modules you are maintaining are being modified, check this out!

@JordiMForgeFlow JordiMForgeFlow force-pushed the 16.0-fix-edi_oca-access_rule-parent branch from 19b35e9 to b9f0a1b Compare September 25, 2024 14:12
@JordiMForgeFlow
Copy link
Contributor Author

@etobella @simahawk could you review this one? :)

simahawk
simahawk reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG... any chance to have a test?

@JordiMForgeFlow JordiMForgeFlow force-pushed the 16.0-fix-edi_oca-access_rule-parent branch from b9f0a1b to b688e14 Compare November 27, 2024 14:05
@JordiMForgeFlow
Copy link
Contributor Author

@simahawk done :)

@simahawk
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-109-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e0bd653 into OCA:16.0 Nov 28, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fb4009a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JordiMForgeFlow @OCA-git-bot @simahawk