-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] edi_oca: Split exchange error and traceback #105
base: 16.0
Are you sure you want to change the base?
Conversation
5ca5d36
to
08d9872
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
c0ae6b4
to
2d674fc
Compare
2d674fc
to
72121d2
Compare
@HviorForgeFlow question: don't you have the traceback on the job? |
Yes I believe that it exists there, but there is no link directly. Error traceback is already in EDI exchange record, the only change in this PR is that as Traceback is usually big and from an user experience prespective someone asked me if I could put just the exception at tree level view to allow them to quick search common errors or understand better without having to enter to the form or look into the linked job. |
We have now a btn to jump to the jobs linked to the record 😉
Exactly because it's big and very technical, I don't think it's a good idea to store it on the record as well. |
But then since 76938cf we are saving the traceback in the exchange records. Should we revert it and just add a optional column in the tree view? |
Ah, good point! Well, I have no strong opinion. For sure, for how things are today is probably better to go ahead w/ this and separate them. Also, having an exchange on error is not normal and will be fixed manually or by an auto operation which means the tb want be stored for too long. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please backport to 14.0?
This PR has the |
Having the exception error in the tree view can be very effective to identify error on several exchange records.
This PR aims to manage the exception message and the traceback in different fields in order let the user classify by error messages in the tree view and also take a look on the traceback on the form view.
CC @ForgeFlow