Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] edi_oca: Split exchange error and traceback #105

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

HviorForgeFlow
Copy link
Member

Having the exception error in the tree view can be very effective to identify error on several exchange records.

This PR aims to manage the exception message and the traceback in different fields in order let the user classify by error messages in the tree view and also take a look on the traceback on the form view.

CC @ForgeFlow

@OCA-git-bot
Copy link
Contributor

Hi @etobella, @simahawk,
some modules you are maintaining are being modified, check this out!

@HviorForgeFlow HviorForgeFlow changed the title [IMP] edi_oca: Split exchange error and traceback [16.0][IMP] edi_oca: Split exchange error and traceback Jul 30, 2024
@HviorForgeFlow HviorForgeFlow force-pushed the 16.0-imp-edi_oca-exchange_error branch 2 times, most recently from 5ca5d36 to 08d9872 Compare July 30, 2024 11:41
Copy link

github-actions bot commented Dec 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 1, 2024
@HviorForgeFlow HviorForgeFlow force-pushed the 16.0-imp-edi_oca-exchange_error branch 2 times, most recently from c0ae6b4 to 2d674fc Compare December 2, 2024 12:28
@HviorForgeFlow HviorForgeFlow force-pushed the 16.0-imp-edi_oca-exchange_error branch from 2d674fc to 72121d2 Compare December 2, 2024 12:32
@simahawk
Copy link
Contributor

simahawk commented Dec 5, 2024

@HviorForgeFlow question: don't you have the traceback on the job?

@HviorForgeFlow
Copy link
Member Author

Yes I believe that it exists there, but there is no link directly.

Error traceback is already in EDI exchange record, the only change in this PR is that as Traceback is usually big and from an user experience prespective someone asked me if I could put just the exception at tree level view to allow them to quick search common errors or understand better without having to enter to the form or look into the linked job.

@simahawk
Copy link
Contributor

simahawk commented Dec 5, 2024

Yes I believe that it exists there, but there is no link directly.

We have now a btn to jump to the jobs linked to the record 😉

Error traceback is already in EDI exchange record, the only change in this PR is that as Traceback is usually big and from an user experience prespective someone asked me if I could put just the exception at tree level view to allow them to quick search common errors or understand better without having to enter to the form or look into the linked job.

Exactly because it's big and very technical, I don't think it's a good idea to store it on the record as well.
Also, on jobs you can already search and group for the exception.

@HviorForgeFlow
Copy link
Member Author

But then since 76938cf we are saving the traceback in the exchange records. Should we revert it and just add a optional column in the tree view?

@simahawk
Copy link
Contributor

simahawk commented Dec 6, 2024

Ah, good point! Well, I have no strong opinion. For sure, for how things are today is probably better to go ahead w/ this and separate them. Also, having an exchange on error is not normal and will be fixed manually or by an auto operation which means the tb want be stored for too long.

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please backport to 14.0?

@simahawk simahawk removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 6, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants