Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] website_sale_product_assortment: bullet list #963

Merged
merged 1 commit into from
Aug 19, 2024
Merged

[IMP] website_sale_product_assortment: bullet list #963

merged 1 commit into from
Aug 19, 2024

Conversation

SirAionTech
Copy link

Better bullet list rendering

@OCA-git-bot
Copy link
Contributor

Hi @CarlosRoca13,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 16.0 milestone Aug 19, 2024
@pedrobaeza
Copy link
Member

This is not [REF], not being a code refactor, but [IMP] (or even [FIX], as indeed this shouldn't be a numbered list).

@SirAionTech
Copy link
Author

This is not [REF], not being a code refactor, but [IMP] (or even [FIX], as indeed this shouldn't be a numbered list).

Thanks for having a look!
It was a REF in my opinion because it does not FIX or IMProve code, but IMP is ok too since it IMProves the README, or I can use FIX, I can't see any clearly right/wrong tag.
Maybe a DOC would be more appropriate, but it does not exist 🤷‍♂️

@CarlosRoca13
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-963-by-CarlosRoca13-bump-minor, awaiting test results.

@SirAionTech SirAionTech changed the title [REF] website_sale_product_assortment: bullet list [IMP] website_sale_product_assortment: bullet list Aug 19, 2024
@OCA-git-bot OCA-git-bot merged commit 325b9aa into OCA:16.0 Aug 19, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c6aa9e0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SirAionTech @OCA-git-bot @pedrobaeza @CarlosRoca13