Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] website_sale_google_tag_manager: Migration to version 15.0 #766

Merged
merged 2 commits into from
Mar 3, 2023
Merged

[15.0][MIG] website_sale_google_tag_manager: Migration to version 15.0 #766

merged 2 commits into from
Mar 3, 2023

Conversation

pilarvargas-tecnativa
Copy link
Contributor

cc @Tecnativa TT41120

@chienandalu @pedrobaeza please review :)

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 15.0-mig-website_sale_google_tag_manager branch from c3c39a3 to 2115b81 Compare March 3, 2023 12:00
@pedrobaeza
Copy link
Member

/ocabot migration website_sale_google_tag_manager

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Mar 3, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 3, 2023
Closed
41 tasks
chienandalu
chienandalu approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-766-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 3, 2023
@OCA-git-bot
Merge PR #766 into 15.0
09ee72a 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-766-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-766-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 066d280 into OCA:15.0 Mar 3, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a63961f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pilarvargas-tecnativa @pedrobaeza @OCA-git-bot @chienandalu