Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] website_sale_b2x_alt_price: Migration to 15.0 #649

Merged
merged 10 commits into from
Dec 26, 2022
Merged

[15.0][MIG] website_sale_b2x_alt_price: Migration to 15.0 #649

merged 10 commits into from
Dec 26, 2022

Conversation

CarlosRoca13
Copy link
Contributor

cc @Tecnativa TT36596

please @Tardo @victoralmau review this

Jairo Llopis and others added 10 commits May 25, 2022 09:05
@CarlosRoca13
[ADD] website_sale_b2x_alt_price: display B2{B,C} complementary price
6ecf4ef 
- If your website is B2B, display a smaller B2C price next to the main one. And viceversa.
- Toggle feature independently in list and product templates.
- Toggle feature per website.
- Supports live price recomputing.

@Tecnativa TT24410
@CarlosRoca13
[FIX] website_sale_b2x_alt_price: l10n resilient tests
24ef839 
When testing on an integration environment which had a different l10n package enabled, the tours failed due to currency rate conversion.

Create instead a test-specific pricelist and reset currency conversions before testing, to avoid false negative tests. That's not the feature being tested here.

@Tecnativa TT24410
@ypapouin @CarlosRoca13
Added translation using Weblate (French)
81fa22b
@ypapouin @CarlosRoca13
Translated using Weblate (French)
509bdb8 
Currently translated at 100.0% (3 of 3 strings)

Translation: e-commerce-12.0/e-commerce-12.0-website_sale_b2x_alt_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_b2x_alt_price/fr/
@claudiagn @CarlosRoca13
Added translation using Weblate (Catalan)
0667e3c
@claudiagn @CarlosRoca13
Translated using Weblate (Catalan)
d9f62f7 
Currently translated at 100.0% (3 of 3 strings)

Translation: e-commerce-12.0/e-commerce-12.0-website_sale_b2x_alt_price
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_b2x_alt_price/ca/
@CarlosRoca13
[IMP] website_sale_b2x_alt_price: black, isort
d54f22f
@CarlosRoca13
[MIG] website_sale_b2x_alt_price: Migration to v13.0
c3a163f
@CarlosRoca13
[IMP] website_sale_b2x_alt_price: black, isort, prettier
a1e62fd
@CarlosRoca13
[MIG] website_sale_b2x_alt_price: Migration to 15.0
6df7ec1
@pedrobaeza
Copy link
Member

/ocabot migration website_sale_b2x_alt_price

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone May 25, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request May 25, 2022
Closed
41 tasks
victoralmau
victoralmau approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK.

@kimasplund
Copy link

any chance of getting the v15 module?

@pedrobaeza
Copy link
Member

Please review this PR to get it merged: https://odoo-community.org/resources/review

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 25, 2022
chienandalu
chienandalu approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-649-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 26, 2022
@OCA-git-bot
Merge PR #649 into 15.0
50aa32c 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 15.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 15.0-ocabot-merge-pr-649-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c4eed4d into OCA:15.0 Dec 26, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b1dad1d. Thanks a lot for contributing to OCA. ❤️

pilarvargas-tecnativa pushed a commit to Tecnativa/e-commerce that referenced this pull request Jan 24, 2023
@OCA-git-bot
Merge PR OCA#649 into 15.0
2a87216 
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@victoralmau victoralmau victoralmau approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
8 participants
@CarlosRoca13 @pedrobaeza @kimasplund @OCA-git-bot @victoralmau @chienandalu @ypapouin @claudiagn