[15.0] [MIG] website_sale_product_sort: MIgration to 15.0 #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_product_sort Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_product_sort/es/
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_product_sort Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_product_sort/fr/
Currently translated at 90.9% (10 of 11 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_product_sort Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_product_sort/nl/
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_product_sort Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_product_sort/ca/
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_sort Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_sort/ca/
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_sort Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_sort/es/
…hanged Co-Authored-By: Pedro M. Baeza <[email protected]>
Currently translated at 100.0% (11 of 11 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_sort Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_sort/nl/
… is_published POST data can contain an empty order, so previous code took that one as the valid, which is not correct. We need to check if there's a value, not only if the key exist. We use also `is_published` as the field for sorting, the same as upstream v13.
|
/ocabot migration website_sale_product_sort |
pedrobaeza
approved these changes
May 23, 2022
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
chienandalu
approved these changes
Dec 26, 2022
|
This PR has the |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at b76539a. Thanks a lot for contributing to OCA. ❤️ |
pilarvargas-tecnativa
pushed a commit
to Tecnativa/e-commerce
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT36606
please @chienandalu @pedrobaeza review this