-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0] [MIG] website_sale_require_legal module #144
[9.0] [MIG] website_sale_require_legal module #144
Conversation
b6cfa82
to
9927793
Compare
{ | ||
"name": "Require accepting legal terms to checkout", | ||
"summary": "Force the user to accept legal tems to buy in the web shop", | ||
"version": "9.0.1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9.0.1.0.0
|
||
This module was written to extend the functionality of your website shop to | ||
support forcing the user to accept your legal advice, terms of use and privacy | ||
policy, and allow you to obey some countries' laws. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/obey/comply with
"license": "AGPL-3", | ||
"application": False, | ||
"installable": True, | ||
"external_dependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove empty keys.
Please rebase on current 9.0 branch, because I have fixed .travis.yml for allowing sass command. |
Is Travis error related to another module? |
Travis is failing due to website_sale_wishlist module, so not related. |
Please rebase again, as sass command is still not working. |
63c8203
to
bf355e8
Compare
This addon breaks a tour in |
The error is also on base branch, so it's not something of this branch. @yajo, please fix it on another PR. |
I hope #149 and OCA/server-tools#666 fix it. |
You need to rebase. |
cbd738b
to
770a691
Compare
770a691
to
36b20df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a coverage drop, but code & functional test passed.
36b20df
to
f8cad91
Compare
@Tecnativa