[MIG] website_sale_require_login: Migration to 17.0

OCA · Oct 2, 2024 · 6425134 · 6425134
1 parent 44df5a9
commit 6425134
Show file tree

Hide file tree

Showing 7 changed files with 53 additions and 84 deletions.
diff --git a/website_sale_require_login/__manifest__.py b/website_sale_require_login/__manifest__.py
@@ -3,13 +3,18 @@
 {
     "name": "Require login to checkout",
     "summary": "Force users to login for buying",
-    "version": "14.0.1.0.0",
+    "version": "17.0.1.0.0",
     "category": "Website",
     "website": "https://github.com/OCA/e-commerce",
     "author": "Tecnativa, " "LasLabs, " "Odoo Community Association (OCA)",
     "license": "AGPL-3",
     "installable": True,
     "depends": ["website_sale_suggest_create_account", "web_tour"],
-    "data": ["views/website_sale.xml", "views/assets.xml"],
+    "data": ["views/website_sale.xml"],
+    "assets": {
+        "web.assets_tests": [
+            "website_sale_require_login/static/tests/tours/checkout.esm.js",
+        ],
+    },
     "post_init_hook": "post_init_hook",
 }
diff --git a/website_sale_require_login/hooks.py b/website_sale_require_login/hooks.py
@@ -6,7 +6,14 @@
 
 def post_init_hook(cr, registry):
     if config["test_enable"] or config["test_file"]:
-        with api.Environment.manage():
-            env = api.Environment(cr, SUPERUSER_ID, {})
-            env.ref("website_sale_require_login.cart").active = False
-            env.ref("website_sale_require_login.short_cart_summary").active = False
+        env = api.Environment(cr, SUPERUSER_ID, {})
+
+        cart_ref = env.ref("website_sale_require_login.cart", raise_if_not_found=False)
+        if cart_ref:
+            cart_ref.active = False
+
+        short_cart_summary_ref = env.ref(
+            "website_sale_require_login.short_cart_summary", raise_if_not_found=False
+        )
+        if short_cart_summary_ref:
+            short_cart_summary_ref.active = False
diff --git a/website_sale_require_login/static/tests/tours/checkout.esm.js b/website_sale_require_login/static/tests/tours/checkout.esm.js
@@ -0,0 +1,34 @@
+/** @odoo-module */
+
+import {registry} from "@web/core/registry";
+
+registry.category("web_tour.tours").add("shop_buy_checkout_required_login_website", {
+    test: true,
+    url: "/shop",
+    steps: () => [
+        // Shop Page
+        {
+            trigger: "td.oe_product a:first",
+        },
+        // Product Page
+        {
+            trigger: "#add_to_cart",
+        },
+        {
+            trigger: 'a.o_navlink_background.btn[href="/shop/cart"]',
+        },
+        {
+            trigger: '.oe_website_sale:not(a.btn-primary[href^="/shop/checkout"])',
+            run: function () {
+                // Check: do nothing
+            },
+        },
+        {
+            trigger: '.oe_website_sale:not(a.btn-default[href^="/shop/checkout"])',
+            run: function () {
+                // Check: do nothing
+            },
+        },
+        // The End
+    ],
+});
diff --git a/website_sale_require_login/static/tests/tours/checkout.js b/website_sale_require_login/static/tests/tours/checkout.js
diff --git a/website_sale_require_login/tests/test_checkout.py b/website_sale_require_login/tests/test_checkout.py
@@ -9,5 +9,4 @@ def test_01_shop_buy(self):
         current_website = self.env["website"].get_current_website()
         current_website.auth_signup_uninvited = "b2b"
         self.env.ref("website_sale_require_login.cart").active = True
-        self.env.ref("website_sale_require_login.short_cart_summary").active = True
         self.start_tour("/shop", "shop_buy_checkout_required_login_website")
diff --git a/website_sale_require_login/views/assets.xml b/website_sale_require_login/views/assets.xml
diff --git a/website_sale_require_login/views/website_sale.xml b/website_sale_require_login/views/website_sale.xml
@@ -8,32 +8,11 @@
         priority="20"
         customize_show="True"
     >
-        <xpath expr="//div[@id='wrap']" position="before">
+        <xpath expr="//t[@t-set='show_shorter_cart_summary']" position="before">
             <t
                 t-set="hide_checkout_button"
                 t-value="not (user_authenticated and can_checkout)"
             />
         </xpath>
-        <xpath
-            expr="//div[hasclass('oe_cart')]//a[@href='/shop/checkout?express=1']"
-            position="attributes"
-        >
-            <attribute name="t-if">not hide_checkout_button</attribute>
-        </xpath>
-        <xpath
-            expr="//div[hasclass('col-12','col-xl-4')]//a[@href='/shop/checkout?express=1']"
-            position="attributes"
-        >
-            <attribute name="t-if">not hide_checkout_button</attribute>
-        </xpath>
-    </template>
-    <template
-        id="short_cart_summary"
-        inherit_id="website_sale.short_cart_summary"
-        customize_show="True"
-    >
-        <xpath expr="//a[@href='/shop/checkout?express=1']" position="attributes">
-            <attribute name="t-if">not hide_checkout_button</attribute>
-        </xpath>
     </template>
 </odoo>