-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] delivery_free_fee_removal: Migration to 18.0 #915
Open
LucasTran380381
wants to merge
13
commits into
OCA:18.0
Choose a base branch
from
LucasTran380381:18.0-mig-delivery_free_fee_removal
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] delivery_free_fee_removal: Migration to 18.0 #915
LucasTran380381
wants to merge
13
commits into
OCA:18.0
from
LucasTran380381:18.0-mig-delivery_free_fee_removal
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not, other tests can fail.
* Standard procedure Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-12.0/delivery-carrier-12.0-delivery_free_fee_removal Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-delivery_free_fee_removal/
[UPD] Update delivery_free_fee_removal.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-13.0/delivery-carrier-13.0-delivery_free_fee_removal Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-13-0/delivery-carrier-13-0-delivery_free_fee_removal/
Description of the issue on OCA#306. In short: the delivery sale line is required in 13.0 to be able: * see which delivery method is used * change the delivery method or update its price * remove the delivery method Removing entirely the line when the fee is free is therefore an issue. The free delivery line is kept, although greyed, in the sale order. However, it is considered as non-invoiceable, so it doesn't create an invoice line, and it is hidden from the sale report. Closes OCA#306 [UPD] Update delivery_free_fee_removal.pot [UPD] README.rst delivery_free_fee_removal 13.0.1.0.1 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-13.0/delivery-carrier-13.0-delivery_free_fee_removal Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-13-0/delivery-carrier-13-0-delivery_free_fee_removal/
The free delivery line stop the order from being fully invoiced. To fix that they are set as invoiced on order confirmation. [UPD] Update delivery_free_fee_removal.pot [UPD] README.rst delivery_free_fee_removal 13.0.1.0.2 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-13.0/delivery-carrier-13.0-delivery_free_fee_removal Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-13-0/delivery-carrier-13-0-delivery_free_fee_removal/
[UPD] Update delivery_free_fee_removal.pot [UPD] README.rst
Currently translated at 100.0% (3 of 3 strings) Translation: delivery-carrier-15.0/delivery-carrier-15.0-delivery_free_fee_removal Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-15-0/delivery-carrier-15-0-delivery_free_fee_removal/es/
/ocabot migration delivery_free_fee_removal |
rousseldenis
reviewed
Dec 6, 2024
rousseldenis
approved these changes
Dec 6, 2024
LucasTran380381
force-pushed
the
18.0-mig-delivery_free_fee_removal
branch
from
December 9, 2024 03:21
778fe6d
to
40c4a55
Compare
ajaniszewska-dev
approved these changes
Dec 9, 2024
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.