Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Remove deb package added by accident #864

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

dreispt
Copy link
Member

@dreispt dreispt commented Jul 19, 2024

No description provided.

@pedrobaeza
Copy link
Member

Doing this, there's a diff of 60 MB instead of 30. A forced push should be done instead for removing this cleanly.

@rousseldenis
Copy link
Contributor

Mmmmh, a force push is not wanted. @sbidoul Any advice ?

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have already debated about this in OCA/oca-addons-repo-template#262, and the alternative is worst for everything.

@sbidoul
Copy link
Member

sbidoul commented Jul 29, 2024

Doing this, there's a diff of 60 MB instead of 30. A forced push should be done instead for removing this cleanly.

FWIW:

❯ du -h .git --max-depth=0
50M .git
❯ git rm *.deb
❯ git commit -m "remove .deb file"
❯ du -h .git --max-depth=0
50M .git

So IMHO, this PR is better than the status quo.

@pedrobaeza
Copy link
Member

I did the same experiment in a fork, and once pushed seems to be the problem. But anyway, I'm going to do the cleanup this week as said, previously announcing it in the contributors list.

@sbidoul
Copy link
Member

sbidoul commented Jul 29, 2024

But anyway, I'm going to do the cleanup this week as said, previously announcing it in the contributors list.

@pedrobaeza I think we need more evidence that this is worthwhile before doing such a disruptive operation.

@pedrobaeza
Copy link
Member

Even if the removal doesn't add size, the inclusion of deb files does, so it must be cleaned.

@sbidoul
Copy link
Member

sbidoul commented Jul 29, 2024

Even if the removal doesn't add size, the inclusion of deb files does, so it must be cleaned.

Well, must is a big word and the tradeoffs are not that all obvious to me. Please make sure to provide data and gather consensus on the contributors mailing list before doing any force push.

@pedrobaeza
Copy link
Member

Yes, because we are wasting a lot of resources. The trade-offs are very little and have direct mitigation actions. That's why I'm so categorical.

@pedrobaeza pedrobaeza dismissed their stale review August 11, 2024 11:58

I desist trying to forced push this

@pedrobaeza pedrobaeza merged commit 88dbb21 into OCA:16.0 Aug 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants