-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] Remove deb package added by accident #864
Conversation
Doing this, there's a diff of 60 MB instead of 30. A forced push should be done instead for removing this cleanly. |
Mmmmh, a force push is not wanted. @sbidoul Any advice ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have already debated about this in OCA/oca-addons-repo-template#262, and the alternative is worst for everything.
FWIW: ❯ du -h .git --max-depth=0 So IMHO, this PR is better than the status quo. |
I did the same experiment in a fork, and once pushed seems to be the problem. But anyway, I'm going to do the cleanup this week as said, previously announcing it in the contributors list. |
@pedrobaeza I think we need more evidence that this is worthwhile before doing such a disruptive operation. |
Even if the removal doesn't add size, the inclusion of deb files does, so it must be cleaned. |
Well, must is a big word and the tradeoffs are not that all obvious to me. Please make sure to provide data and gather consensus on the contributors mailing list before doing any force push. |
Yes, because we are wasting a lot of resources. The trade-offs are very little and have direct mitigation actions. That's why I'm so categorical. |
No description provided.