-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][MIG] delivery_carrier_label_batch - Migration to 14.0 #468
[14.0][MIG] delivery_carrier_label_batch - Migration to 14.0 #468
Conversation
- change name to batch to match with change of `picking_dispatch` name to `stock_batch_picking` - mode description in README.rst - move files in models and views directories - change headers to small license header - use api 8.0 - fix and improve tests
the field has been renamed in the base module
Probably due to usage of multiple environment and cache. datas can't be read from shipping.label but it can be read from ir.attachment
When there is more than 1 pack in a picking, 2 or more thread worker might be in concurrence on the same picking, which makes one of the transaction fails, resulting in the abort of the whole label generation. The solution implemented is to change the way of passing the tasks to the thread workers. Instead of passing a label at a time, we pass a group of label. A group of label actually contains all the labels to generate for one picking.
Co-Authored-By: Alexandre Fayolle <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-12.0/delivery-carrier-12.0-delivery_carrier_label_batch Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-delivery_carrier_label_batch/
Hey @khoivo1601, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
This PR to replace the PR #452. One small update is change the action_generate_carrier_label method to the send_to_shipper method (I have a problem with 2FA. So, I can't login to update the PR #452 directly. Sorry for the inconvenience) |
/ocabot migration delivery_carrier_label_batch |
@khoivo1601 dependency has been merged, can you remove [TMP] commit? |
f831c4e
to
939b8aa
Compare
@khoivo1601 thanks! /ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 92eb49d. Thanks a lot for contributing to OCA. ❤️ |
Depends on: