-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0] base_delivery_carrier_label: add check when no carrier_id assigned #455
[14.0] base_delivery_carrier_label: add check when no carrier_id assigned #455
Conversation
93dedde
to
45d1b4d
Compare
45d1b4d
to
a5b356a
Compare
… package in _set_a_default_package.
… for delivery type other than postlogistics.
1b36110
to
a5b356a
Compare
…gned and fix import mock bug
a5b356a
to
1300c81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG. just a minor comment
This PR has the |
455cfcd
to
7eb918d
Compare
When there is no carrier, destination_type is false and can cause error. In the case, `one` destination_type should be used.
7eb918d
to
acfe58e
Compare
/ocabot merge patch |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 980edb3. Thanks a lot for contributing to OCA. ❤️ |
Add check when no carrier assigned on picking
Fix
import mock
Merge with PR#458 to improve and fix conflict
_set_default_package
frombase_delivery_carrier_label
delivery_carrier_pricelist
module testdelivery_package_fee
module testdelivery_type
check indelivery_postlogistics
delivery_type
check indelivery_multi_destination