Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] delivery_roulier_laposte_fr tests: mute vcr.cassette logger #404

Conversation

nilshamerlinck
Copy link
Contributor

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @nilshamerlinck! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the maintainers key of the addon manifest.

super().setUp(*args, **kwargs)
# the cassettes for this case contain some big requests
# that are causing travis build to fail when logged
with tools.mute_logger("vcr.cassette"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can decorate the whole class 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe but I wanted to limit the impact of this mute to the only problematic part: https://github.com/kevin1024/vcrpy/blob/master/vcr/cassette.py#L228

@simahawk
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-404-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b5606b7 into OCA:14.0 Aug 16, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 31496ee. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants