Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14.0 mig delivery carrier label default #396

Closed
wants to merge 16 commits into from
Closed

14.0 mig delivery carrier label default #396

wants to merge 16 commits into from

Conversation

KKamaa
Copy link

@KKamaa KKamaa commented Jul 17, 2021 •
edited
Loading

migration to v14.0, see sample below; it contains default label and generating .csv docs all in one sample.

delivery-carrier

@KKamaa KKamaa force-pushed the 14.0-mig-delivery_carrier_label_default branch 2 times, most recently from db1b85f to 200a99c Compare July 17, 2021 23:38
gfcapalbo
gfcapalbo suggested changes Nov 23, 2021
View reviewed changes
Copy link

@gfcapalbo gfcapalbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi Decorator is deprecated in v14, please remove,
the rest looks consistent with the last known version on v11.
I see no differences in the report.render method, so it should work the same.

Approved after decorator removal.

delivery_carrier_label_default/models/stock_picking.py Outdated
class StockPicking(models.Model):
_inherit = "stock.picking"

@api.multi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multi is deprecated in 14.0 remove or will gen error

gfcapalbo
gfcapalbo suggested changes Nov 23, 2021
View reviewed changes
delivery_carrier_label_default/__manifest__.py Outdated
"license": "AGPL-3",
"installable": True,
"depends": [
"stock",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant, it is already installed via the dependency chain below:

base_delivery_carrier_label -> delivery_carrier_info -> delivery -> sale_stock ->stock_account -> [ stock ]

yvaucher and others added 14 commits February 27, 2022 01:13
@yvaucher @KKamaa
Rename delivery_carrier_label_default_webkit module to delivery_carri…
d34d741 
…er_label_default as it will uses qweb
@yvaucher @KKamaa
[9.0] port default label module + tests
c2ba825 
Add tests on generating default label
@sebalix @KKamaa
[MIG] delivery_carrier_label_default: migration to 11.0
4bbcac9
@oca-travis @KKamaa
[UPD] Update delivery_carrier_label_default.pot
5502260
@sergio-teruel @KKamaa
[11.0][FIX] delivery_carrier_label_default: Fix print one label per page
00bdc2d
@OCA-git-bot @KKamaa
[UPD] README.rst
fc341ad
@OCA-git-bot @KKamaa
[UPD] README.rst
4501e87
@KKamaa
[12.0][MIG] delivery_carrier_label_default migrate
3592e4e
@KKamaa
[REF] update to changes in base_delivery_carr_lab
1fcfa0e 
due to changes sugested in ffaab97 now label always will be generated
for package

[FIX] prepare data for attachment in base64

to  refactoring in 86552f8, attachment should save their
data in base64
@KKamaa
[REF] update tests to 86552f8
f4c76b2
@oca-travis @KKamaa
[UPD] Update delivery_carrier_label_default.pot
68245f4
@OCA-git-bot @KKamaa
[UPD] README.rst
156f458
@KKamaa
[UPD] delivery_carrier_label_default: black, isort, prettier
b93deda
@KKamaa
[MIG] migration to v14.0
d68f715
@KKamaa KKamaa force-pushed the 14.0-mig-delivery_carrier_label_default branch from add714c to d68f715 Compare February 26, 2022 22:15
@github-actions
Copy link

github-actions bot commented Jul 3, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 3, 2022
@KKamaa
Copy link
Author

KKamaa commented Jul 4, 2022

@OCA/community-maintainers can someone do a check on this please

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 10, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 13, 2022
@KKamaa
Copy link
Author

KKamaa commented Nov 14, 2022

@thomaspaulb we are currently using this in our own 14.0 migration its labelled as stale

@sebalix
Copy link
Contributor

sebalix commented Nov 15, 2022

@KKamaa Hello, we didn't saw your PR this year (the title was skipping the _ in the name of the module so we didn't find it), so we did this one earlier this year: #456

I compared both migration commits and there are quite some changes between them, I can't say which one is better. What I know is we are using the linked PR above in production for some months now without issues, can you have a look at it please?

@sebalix sebalix added this to the 14.0 milestone Nov 15, 2022
@sebalix
Copy link
Contributor

sebalix commented Nov 15, 2022

@sonhd91 Can you have a look on this one too?

@thomaspaulb thomaspaulb mentioned this pull request Nov 15, 2022
Closed
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 20, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 26, 2023
@github-actions github-actions bot closed this Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfcapalbo gfcapalbo gfcapalbo requested changes

Assignees
No one assigned
Labels
migration stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@KKamaa @sebalix @gfcapalbo @yvaucher @oca-travis @sergio-teruel @OCA-git-bot