-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] l10n_es_cooperator: Add VAT for partner in cooperator module #51
Conversation
21a1227
to
727e5bb
Compare
727e5bb
to
12c1c34
Compare
12c1c34
to
287709e
Compare
@robinkeunen @remytms hi! Would be OK for you to have the spanish localization for cooperator in this repo? It seems that the spanish localization works differently compared to the belgian (OCA/l10n-spain#2810). |
Sorry Cesar, I was not in front of my computer last week. Can you improve code coverage ? Hugues has added a lot of helper functions to add tests to cooperator modules. @huguesdk should we bring back |
i’m not sure what the oca policy is regarding where to place localization modules for non-core domains. putting them in the domain repository might result in many modules being present while most of them being useless to the user. on the other hand, putting all localization modules in the country’s localization repository might result in many modules from many different domains in the same repository, under the responsibility of the country’s localization psc, which might also not be desirable. this question should be asked on the contributors mailing list. |
@cesarlr can you ask on the contributor list ? We have modules
|
Ok! I will ask on it!
El 9 de febrero de 2023 15:56:47 CET, Robin Keunen ***@***.***> escribió:
…
@cesarlr can you ask on the contributor list ? We have modules
- l10n_be_cooperator already in l10n-belgium
- l10n_ch_cooperator still in vertical-cooperative
- l10n_fr_cooperator still in vertical-cooperative
--
Reply to this email directly or view it on GitHub:
#51 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
/ocabot merge patch |
On my way to merge this fine PR! |
It looks like something changed on |
It looks like something changed on |
Congratulations, your PR was merged at a6426f4. Thanks a lot for contributing to OCA. ❤️ |
No description provided.