Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] l10n_es_cooperator: Add VAT for partner in cooperator module #51

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

cesarlr
Copy link
Contributor

@cesarlr cesarlr commented Jan 31, 2023

No description provided.

@cesarlr
Copy link
Contributor Author

cesarlr commented Jan 31, 2023

OCA/l10n-spain#2810

@enricostano
Copy link
Contributor

@robinkeunen @remytms hi! Would be OK for you to have the spanish localization for cooperator in this repo? It seems that the spanish localization works differently compared to the belgian (OCA/l10n-spain#2810).

@robinkeunen
Copy link
Contributor

Sorry Cesar, I was not in front of my computer last week. Can you improve code coverage ? Hugues has added a lot of helper functions to add tests to cooperator modules.

@huguesdk should we bring back l10n_be_cooperator?

@huguesdk
Copy link
Member

huguesdk commented Feb 7, 2023

i’m not sure what the oca policy is regarding where to place localization modules for non-core domains. putting them in the domain repository might result in many modules being present while most of them being useless to the user. on the other hand, putting all localization modules in the country’s localization repository might result in many modules from many different domains in the same repository, under the responsibility of the country’s localization psc, which might also not be desirable. this question should be asked on the contributors mailing list.

@robinkeunen
Copy link
Contributor

@cesarlr can you ask on the contributor list ? We have modules

  • l10n_be_cooperator already in l10n-belgium
  • l10n_ch_cooperator still in vertical-cooperative
  • l10n_fr_cooperator still in vertical-cooperative

@cesarlr
Copy link
Contributor Author

cesarlr commented Feb 9, 2023 via email

@robinkeunen
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-51-by-robinkeunen-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 10, 2023
Signed-off-by robinkeunen
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-51-by-robinkeunen-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 10, 2023
Signed-off-by robinkeunen
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-51-by-robinkeunen-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c732bb6 into OCA:12.0 Mar 10, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a6426f4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants