Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] contract_payment_mode: Migration to 17.0 #1116

Merged
merged 47 commits into from
Sep 3, 2024

Conversation

Tisho99
Copy link
Contributor

@Tisho99 Tisho99 commented Aug 11, 2024

Standard migration

Added little improvements requested by Rousseldenis

Supersedes #1088

T-6501

@Tisho99 Tisho99 marked this pull request as draft August 11, 2024 14:25
@Tisho99 Tisho99 force-pushed the 17.0-mig-contract_payment_mode branch 5 times, most recently from f8f1cc3 to 369a627 Compare August 11, 2024 15:22
@Tisho99 Tisho99 marked this pull request as ready for review August 11, 2024 15:25
@Tisho99
Copy link
Contributor Author

Tisho99 commented Aug 11, 2024

@HaraldPanten
Copy link

@pedrobaeza could you assign this migration to us, and close the other migration PR?

@rousseldenis Could you help us with the reviews? THX!

@pedrobaeza
Copy link
Member

/ocabot migration contract_payment_mode

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

willer-mo and others added 18 commits September 2, 2024 12:48
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-16.0/contract-16.0-contract_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_payment_mode/
Currently translated at 100.0% (2 of 2 strings)

Translation: contract-16.0/contract-16.0-contract_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_payment_mode/es/
Currently translated at 100.0% (2 of 2 strings)

Translation: contract-16.0/contract-16.0-contract_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_payment_mode/nl/
Currently translated at 100.0% (2 of 2 strings)

Translation: contract-16.0/contract-16.0-contract_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_payment_mode/it/
Currently translated at 100.0% (2 of 2 strings)

Translation: contract-16.0/contract-16.0-contract_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_payment_mode/hr/
Currently translated at 100.0% (2 of 2 strings)

Translation: contract-16.0/contract-16.0-contract_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_payment_mode/it/
@Tisho99 Tisho99 force-pushed the 17.0-mig-contract_payment_mode branch from 369a627 to 3f7ba23 Compare September 2, 2024 10:59
@Tisho99
Copy link
Contributor Author

Tisho99 commented Sep 2, 2024

@ValentinVinagre @HaraldPanten

I updated the PR to your requested changes

Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza could we merge this one?

THX!

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1116-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit dd7b1f4 into OCA:17.0 Sep 3, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 350ed63. Thanks a lot for contributing to OCA. ❤️

@ValentinVinagre ValentinVinagre deleted the 17.0-mig-contract_payment_mode branch September 3, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.